Skip to content

Conversation

@adoy
Copy link
Contributor

@adoy adoy commented Jan 10, 2022

No description provided.

@l0gicgate l0gicgate added this to the 4.10.0 milestone Jan 10, 2022
@Midel3
Copy link

Midel3 commented Jan 12, 2022

This should also resolve this issue: bshaffer/oauth2-server-php#254

PHP tends to overwrite the status code to 401 whenever a WWW-Authenticate header is present, while 400, 403 and 405 are allowed according to RFC6750

@odan
Copy link
Contributor

odan commented Jan 12, 2022

It looks good to me. This is also how it is done in Laminas, see SapiEmitter.

@coveralls
Copy link

coveralls commented Jan 13, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 85cf515 on adoy:fix-1739 into 2b74627 on slimphp:4.x.

@l0gicgate l0gicgate merged commit 6aa522d into slimphp:4.x Jan 13, 2022
@adoy adoy deleted the fix-1739 branch January 14, 2022 05:18
chriscct7 pushed a commit to awesomemotive/aioseo-slim-v3-php-8.1 that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants