Refactor some code #3218
Merged
Refactor some code #3218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbayramberdiyev
suggested changes
Jul 6, 2022
tests/bootstrap.php
Outdated
| return false; | ||
| } | ||
| return true; | ||
| return ! (stripos($file, 'non-readable.cache') !== false) |
Contributor
There was a problem hiding this comment.
You can simply do this:
return stripos($file, 'non-readable.cache') === false;
Contributor
Author
There was a problem hiding this comment.
Thanks, this is a better way.
Contributor
There was a problem hiding this comment.
Can you also unwrap the code parentheses?
Contributor
Author
There was a problem hiding this comment.
I unwrapped the code parentheses.
tests/bootstrap.php
Outdated
| return false; | ||
| } | ||
| return true; | ||
| return ! (stripos($path, 'non-writable-directory') !== false) |
nbayramberdiyev
approved these changes
Jul 7, 2022
l0gicgate
approved these changes
Jul 7, 2022
chriscct7
pushed a commit
to awesomemotive/aioseo-slim-v3-php-8.1
that referenced
this pull request
Sep 3, 2025
Refactor some code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.