Make regex matching stable and optimize brand name and device type lookups#6
Open
WingGithub wants to merge 2 commits into
Open
Make regex matching stable and optimize brand name and device type lookups#6WingGithub wants to merge 2 commits into
WingGithub wants to merge 2 commits into
Conversation
added 2 commits
February 3, 2026 07:27
…rays for stable parsing results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An user agent like "Roku/DVP-14.0 (14.0.0.6047-30)" can potentially match either the regex for "Roku" or "Unknown" in a random manner because the order of iterating a golang map of regex values is non deterministic unlike a PHP array which is sorted. We want the user agent to alway match the regex for "Roku" first before matching the catch all regex for "Unknown".
The device type and brand name lookups are iterating through a map in a loop instead of using map lookups directly which is the correct way to use maps. For reverse lookups, we can create a reverse lookup maps which will also optimize lookup speed.