…ift, error boundary (#125) * fix: staged-run lifecycle reliability + chain-of-custody/contract fixes From the 2026-05-30 full review (audits/full-review-2026-05-30.md). Staged-run lifecycle (P1/P2 reliability cluster): - Register pitch-note + MT3 subprocesses for interruption so interrupt/delete actually terminate them instead of orphaning multi-GB children up to their 600s/1800s timeout; route both through the proven _run_streamed_subprocess. - Terminalize interpretation and measurement attempts on setup failure (were left 'running' forever with no reaper). - Guard every attempt/measurement transition against resurrecting an interrupted row, and gate the measurement follow-up enqueue on the guarded update so a cancelled run can't spawn a fresh pipeline. - Frontend monitorAnalysisRun: overall wall-clock budget + per-poll deadline (was an unbounded poll loop with no per-request timeout). Chain-of-custody + quick wins: - Phase 1 parser now carries reverbDetail.perBandRt60 / preDelayMs and vocalDetail.stemEnergyRatio / stemOtherCorrelation -- prompt-citable fields it silently dropped, which broke the citation-existence check. - normalizeKey no longer rewrites "major" into "majoror" (false key contradiction on a valid "Maj" abbreviation). - Define _FILE_CACHE_LOCK / _FILE_CACHE_TTL_SECONDS and import timedelta -- latent NameError in the (currently unwired) temp-file cache path. - Add a React ErrorBoundary around the lazy AnalysisResults Suspense so one render or chunk-load failure can't blank the whole app. Tests: backend resurrection + temp-file-cache regressions (+ caught a second undefined name, timedelta); frontend parser/validator/citation contract, normalizeKey, and polling-timeout regressions. Backend 1068 green, frontend 713 green, lint + production build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: address review follow-ups + ErrorBoundary fallback smoke test Bundles the P3/LOW findings from the sequential review of e3e0f69 (verdict: ship-as-is) plus the ErrorBoundary fallback-render coverage. 1. Backend orphan guard (analysis_runtime.py): _enqueue_requested_followups now re-asserts measurement.status == 'completed' before creating follow-up rows. Closes the cross-transaction window where an interrupt committing between complete_measurement's guarded update and the (separate) enqueue transaction would leave inert 'queued' rows on a cancelled run. 2. Faithful MT3 mock-timeout (server.py): the mock branch of _run_streamed_subprocess now coerces bytes streams to text via _stream_text, matching the real branch's text=True contract — so a TimeoutExpired carrying bytes reaches the timeout-specific branch instead of a str-in-bytes TypeError that the broad except masked. Test tightened to assert the timeout message. 3. Bound the mid-loop interpretation POST (analyzer.ts): extracted the race-with-neutralized-fetch logic into an exported raceWithDeadline<T> helper and wrapped the stem-summary createInterpretationAttempt POST in it, closing the last unbounded await in the poll loop. 4. ErrorBoundary docstring: corrected the "Try again" claim — React.lazy caches a rejected import, so it recovers a render-throw but not a chunk-load failure ("Reload page" does). No behavior change. 5. ErrorBoundary fallback smoke test (tests/smoke/error-boundary.spec.ts): drives a mocked run to the results view, aborts the lazy AnalysisResults chunk, and asserts the fallback renders (alert + Try again/Reload). Verified meaningful: it fails when the boundary is removed. Updates the unit-test caveat comment. Tests: backend 1069 green (+1 orphan-race regression), frontend 716 green (+3 raceWithDeadline) + lint clean + the new smoke spec passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: lock the measurement + interpretation setup-failure terminalizers Follow-up to the 2026-05-30 review fixes (PR #125). The resurrection guards and the #12 cache path already had regressions, but the two terminalizers this branch ADDED — #7 (_execute_measurement_run source-artifact guard) and #3/#6 (_execute_interpretation_attempt setup wrapper) — rode on the pre-existing MT3 sibling test (test_source_artifact_failure_terminalizes_attempt) with no regression of their own. A reverted guard would have stayed green. Add StageSetupFailureTerminalizationTests, one test per stage, mirroring the MT3 sibling: reserve the stage, make source/grounding resolution raise, and assert the stage terminalizes to 'failed' with the expected error code instead of wedging in 'running'. Verified meaningful — both error out when the terminalizer's except is neutered. Backend 1071 green (+2). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Github Compatibility #12

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions