docs(incorporations): forking plans for 5 audio-MIR discoveries (ASA + Harmonia) - #50
Conversation
…+ Harmonia) Five concrete incorporation plans for upstreams surfaced in the 2026-05-13 / 2026-05-14 audio-MIR discovery passes, mirroring the seven-part track structure of docs/external-repo-review-2026-05-13.md (Source / What to lift / Why / Approach / Cross-check oracle / Definition of done / Risks): - Plan 4 — audio-analyzer-rs (MIT, Rust binary MCP server): cross-check oracle first; fork-to-WASM gated on a concrete in-browser need that ASA doesn't have today. - Plan 5 — resonators (dual MIT/Apache-2.0, published npm WASM): incorporate as a dependency for a new browser-side spectral preview; the near-drop-in. - Plan 6 — jivetalking (GPL-3.0-only, Go): clean-room port of the measure-then-derive-parameters pattern into Phase 2 recommendation logic; license blocks any code path. - Plan 7 — ChordMiniApp (MIT, Next.js + Flask + Firebase): reference-only UX + architecture review for Harmonia, with explicit adopt / adapt / reject per surface. - Plan 8 — chordonomicon (Apache-2.0 scripts, CC-BY-NC-4.0 dataset): HF dataset eval harness for Harmonia; NonCommercial license gates product inclusion. Plans 4 and 5 cross-reference each other (both Rust → WASM stories on paper, with different ROI profiles). Plan 6 composes with the prior review's Track 1 finding (ASA's Essentia loudness is correct on stereo) by sourcing measurement inputs from existing Phase 1 rather than a new measurement layer. Plan 7 ↔ Plan 8 compose: 7 sets the chord-presentation UX bar, 8 provides labeled ground truth. License discipline: all five licenses confirmed against the upstream (MIT, dual MIT/Apache, GPL-3.0-only, MIT, Apache-2.0 scripts + CC-BY-NC-4.0 data). Two plans carry license risk — jivetalking (GPL, no source-reading for the port) and chordonomicon (NC, no commercial inclusion); both make license confirmation item 1 of their DoD. The task brief referenced a separate routine-discoveries repository with discoveries/*.md source-of-truth files and an asa-2026-05-13.md template. Those files are not present in this checkout (scoped to ableton-sonic-analyzer). The plan was written from the task description + direct upstream research + the prior external-repo-review for house style; see the Environment note in the document header. https://claude.ai/code/session_017Pt2pELLM2qNQxoZrWQt4M
slittycode
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Summary
Docs-only PR — one new file (incorporations/forking-plans-2026-05-14.md, 942 lines). No code, no schema changes, no test impact. The license discipline is careful (GPL-3.0 and CC-BY-NC-4.0 risks are correctly flagged and made DoD item 1), the adopt/adapt/reject tables are well-reasoned, and the sequencing recommendation maps accurately to effort and risk. No phase boundary violations possible in a plan-only doc.
Findings
Should fix
Plan 6 DoD is missing the frontend types contract. The DoD correctly says to update apps/backend/JSON_SCHEMA.md and EXPECTED_TOP_LEVEL_KEYS in test_analyze.py when adding noise-floor estimate and spectral flux to Phase 1. It does not mention updating apps/ui/src/types/measurement.ts. CLAUDE.md tripwire #3 is explicit: renaming or adding a field on only one side of the Python/TS boundary is undetectable by either type system — the field just disappears from the UI. Whoever picks up Plan 6 will hit this if the DoD checklist is followed as written. Add apps/ui/src/types/measurement.ts to that checklist.
Worth considering
Plan 5 DoD doesn't enforce its own stated guardrails. The Approach section says "behind a feature flag" and the Risks section says "The preview is labeled as approximate." Neither appears as a DoD checkbox. Given the risk that users will interpret a resonators-derived browser preview as a Phase 1 measurement (cited in the Risks table, severity: Medium), these two items belong in the DoD as testable conditions, not prose asides.
Plan 5's "after PR #45, Phase 3 already audits heuristic WAV/MIDI" is either wrong or ambiguous. Per BACKLOG.md and CLAUDE.md, patchSmith.ts (Phase 3) is still an open backlog item, not shipped. If PR #45 lands Phase 3, that reference will be fine post-merge; if not, the sentence is describing a future state as a present fact. Either clarify that this is conditional on #45 merging, or remove the parenthetical.
Test results
N/A — plan-only document.
Phase boundary check
Clean. No code. The plans, particularly Plan 5 (browser-side resonators preview vs. server-side Phase 1 measurements), explicitly call out the boundary and the oracle pattern for validating it. The "Phase 1 stays the cited number throughout the UI" principle is correctly restated.
Generated by Claude Code
Three fixes from the review on #50: - Plan 6 DoD: add apps/ui/src/types/measurement.ts to the field-addition checklist alongside JSON_SCHEMA.md and EXPECTED_TOP_LEVEL_KEYS. CLAUDE.md tripwire #3 — Python emits camelCase JSON directly, so a Python-side addition without the TS counterpart disappears silently from the UI. - Plan 5 DoD: add a testable item enforcing the "preview is approximate, not a Phase 1 measurement" guardrail that previously lived only in the Risks prose. - Plan 5 prose: disambiguate Phase 3 audition (shipped, #45) from Phase 3 synth-patch generation (open, patchSmith.ts) and fix the broken link that pointed at README.md instead of the PR / design doc. https://claude.ai/code/session_017Pt2pELLM2qNQxoZrWQt4M
Summary
Adds
incorporations/forking-plans-2026-05-14.md— five concrete forking / incorporation plans for upstreams from the 2026-05-13 / 2026-05-14 audio-MIR discovery passes. Three ASA-facing, two Harmonia-facing. Plan-only — no implementation.Mirrors the seven-part track structure of
docs/external-repo-review-2026-05-13.md(Source / What to lift / Why / Approach / Cross-check oracle / Definition of done / Risks), and extends the prior review's Track-1–3 numbering with Plans 4–8.npm install resonators) — the near-drop-inComposition & cross-references
License discipline
All five upstream licenses confirmed against the source. Two carry real risk and make license confirmation item 1 of their DoD:
Environment note
The task brief referenced a separate
routine-discoveriesrepository withdiscoveries/*.mdsource-of-truth files and anasa-2026-05-13.mdtemplate. Those files are not present in this checkout (which is scoped toableton-sonic-analyzer). I checked with the user before proceeding; the plan was written using the task description as the spec, direct upstream research for licenses / APIs / schemas, anddocs/external-repo-review-2026-05-13.mdas house-style reference. See the "Environment note" paragraph in the document header.Sequencing recommendation
Test plan
This is a plan-only document — no code, no tests to run. Reviewer checks:
https://claude.ai/code/session_017Pt2pELLM2qNQxoZrWQt4M
Generated by Claude Code