Skip to content

feat(ui): D.6a wrap MeasurementDashboard in DeviceRack + migrate cards #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slittycode merged 1 commit into from
May 18, 2026
Merged

feat(ui): D.6a wrap MeasurementDashboard in DeviceRack + migrate cards #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions apps/ui/src/components/MeasurementDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { MiniHeatmap } from './MiniHeatmap';
import { ConfidenceBandBadge } from './sessionMusician/ConfidenceBandBadge';
import { MixDoctorPanel } from './MixDoctorPanel';
import {
AccentMetricCard,
DeltaBadge,
MetricBar,
MetricBarRow,
Expand All @@ -34,6 +33,7 @@ import {
StyledDataTable,
TokenBadgeList,
} from './MeasurementPrimitives';
import { DeviceRack, MetricTile } from './ui';
import { Sparkline } from './Sparkline';
import { SpectralCursorProvider } from '../hooks/useSpectralCursorBus';
import { formatDisplayText, getTextRoleClassName } from '../utils/displayText';
Expand Down Expand Up @@ -1310,7 +1310,8 @@ export function MeasurementDashboard({
}, [apiBaseUrl, runId, generating]);

return (
<div data-testid="measurement-dashboard" className="space-y-4">
<DeviceRack name="Measurements" density="dense" status="success">
<div data-testid="measurement-dashboard" className="space-y-4">
{/* 1. Core Metrics */}
<Section id="section-meas-core" number={1} title="Core Metrics">
{/* Hero Grid */}
Expand All @@ -1321,7 +1322,7 @@ export function MeasurementDashboard({
twice at different precisions ("157" up top, "156.6" here) inside
one scroll region read as a measurement disagreement to producers.
Precision is preserved in the Percival sub-label below. */}
<AccentMetricCard
<MetricTile size="xl"
label="Tempo"
value={Math.round(phase1.bpm)}
unit="BPM"
Expand Down Expand Up @@ -1361,7 +1362,7 @@ export function MeasurementDashboard({
/>

{/* Key Tile */}
<AccentMetricCard
<MetricTile size="xl"
label="Key Signature"
value={<span className="truncate block">{phase1.key || '—'}</span>}
footer={
Expand All @@ -1380,7 +1381,7 @@ export function MeasurementDashboard({
/>

{/* Duration / Format Tile */}
<AccentMetricCard
<MetricTile size="xl"
label="Duration"
value={formatDuration(phase1.durationSeconds)}
unit={phase1.timeSignature}
Expand Down Expand Up @@ -1658,7 +1659,7 @@ export function MeasurementDashboard({
{ label: 'True Peak', value: phase1.truePeak, suffix: 'dBTP', decimals: 2 },
].filter((tile) => tile.value !== undefined && tile.value !== null).map((tile) => (
<div key={tile.label}>
<AccentMetricCard
<MetricTile size="xl"
label={tile.label}
value={formatNumber(tile.value!, tile.decimals)}
unit={tile.suffix ? <span className="text-[8px] font-mono text-text-secondary/45">{tile.suffix}</span> : undefined}
Expand Down Expand Up @@ -1862,7 +1863,7 @@ export function MeasurementDashboard({
)}
</div>
) : (
<AccentMetricCard
<MetricTile size="xl"
label="Dynamics & Texture"
value={dynamicsTextureFallback.title}
unit={<span className="text-[8px] font-mono uppercase tracking-wide text-text-secondary/45">Unavailable</span>}
Expand Down Expand Up @@ -2809,6 +2810,7 @@ export function MeasurementDashboard({
)}
</div>
</Section>
</div>
</div>
</DeviceRack>
);
}
Loading