Closed
Conversation
Author
|
@olegklimov please help review and feel free to test. The inference is extremely fast with the effort from llama.cpp. |
|
It is really fast! Nice work! |
olegklimov
pushed a commit
that referenced
this pull request
Feb 17, 2025
* wip(patch show apply): fetch the patch data from the lsp * fix(patchResult type guard): add proper type checks for patchResult. * feat(pin open): open an unsaved file in the ide. * refactor(pin): use a stricter regexp for detecting the end of the markdown. * feat(pins): add apply button and share chunks cache with diffs. * feat(pins): allow the ide to reset the diff cache when applying / saving diffs * ui(markdown): limit pin messages to only assistant messages. * ui(pin buttons): wrap buttons above long 📍 message * chore(pins): remove todos and hide show button in web host * refactor(pin): lazily fetch chunks and show warning / error message if result doesn't work. * ui(pin): move callout to bellow the button * chore(dev max age for dev tools): decrease to 500 * refactor(pin warning): reuse diff warning callout * refactor(pin callout): add click handler and timeout props.
Member
|
@mitya52 do we still need this? |
Contributor
|
Refact model is obsolete, so we'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #77
reference PR: ggml-org/llama.cpp#3329