fix: remove redundant obj variable in allocator functions#8
Merged
takaokouji merged 1 commit intoApr 2, 2026
Merged
Conversation
Return TypedData_Make_Struct directly instead of assigning to a temporary variable in DisplayMode_s_allocate, Rect_s_allocate, and Point_s_allocate where obj is not used before return. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address review feedback from upstream PR (ohai#30) to remove redundant
objvariable assignments in allocator functions.Changes Made
video.c.m4: Remove redundantVALUE objinDisplayMode_s_allocate,Rect_s_allocate, andPoint_s_allocate— returnTypedData_Make_Struct(...)directly instead of assigning to a temporary variable.These functions only call
TypedData_Make_Structand immediately return the result, so the intermediate variable adds no value.Functions where
objis used before return (e.g.,Renderer_new,Window_new) are unchanged per reviewer guidance.Verification
ruby extconf.rb && make