CalendarDeletedResponse accepts 2 arguments, not 3 - #4
Merged
Conversation
It accepts a 'body' and (return) 'code' argument, but in the code here 'calendar_url' was erroneously passed in as first argument
Contributor
Author
|
Hi! Your CalDav client is by far the cleanest and best implementation I could find, thoroughly non-sucky and very modern. Thanks for writing it, and thank you for open sourcing it! You're probably a busy guy so I'll just keep on submitting pull requests to address issues as I find them. Hope you don't mind. |
Owner
|
Hey, first at all thank you for your interesest on this lib, just wrote it bc same reasons that u already depicted , i will review changes and will merge when i got some free time :) |
Contributor
Author
|
Awesome, thanks! |
anvanvan
pushed a commit
to anvanvan/CalDAVClient
that referenced
this pull request
Nov 13, 2025
CalendarDeletedResponse accepts 2 arguments, not 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It accepts a 'body' and (return) 'code' argument, but in the code here 'calendar_url' was erroneously passed in as first argument