fix token pool tooling - #482
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CCIP token pool tooling by ensuring remote pool addresses are encoded as raw bytes derived from hex strings (instead of ASCII bytes), and by simplifying configuration sequences to rely on ApplyChainUpdates for remote pool additions.
Changes:
- Convert
RemotePoolAddressfrom hex string to[]byteviadeployment.StrToByteswhen encodingAddRemotePool/RemoveRemotePoolcalls. - Remove redundant per-chain
AddRemotePoolexecution from burn-mint and managed token pool configure sequences (remote pools are handled viaApplyChainUpdates). - Update MCMS proposal-data tests to use hex-formatted addresses and to mirror the new encoding logic.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/ops/ccip_managed_token_pool/seq_configure.go | Removes per-chain remote pool add loop; relies on ApplyChainUpdates for remote pool configuration. |
| deployment/ops/ccip_managed_token_pool/op_managed_token_pool.go | Uses StrToBytes for remote pool address encoding in add/remove remote pool ops. |
| deployment/ops/ccip_managed_token_pool/op_managed_token_pool_mcms_test.go | Updates tests to use hex address strings and match StrToBytes encoding. |
| deployment/ops/ccip_lock_release_token_pool/op_lock_release_token_pool.go | Uses StrToBytes for remote pool address encoding in add/remove remote pool ops. |
| deployment/ops/ccip_lock_release_token_pool/op_lock_release_token_pool_mcms_test.go | Updates tests to use hex address strings and match StrToBytes encoding. |
| deployment/ops/ccip_burn_mint_token_pool/seq_configure.go | Removes per-chain remote pool add loop; relies on ApplyChainUpdates for remote pool configuration. |
| deployment/ops/ccip_burn_mint_token_pool/op_burn_mint_token_pool.go | Uses StrToBytes for remote pool address encoding in add remote pool op. |
| deployment/ops/ccip_burn_mint_token_pool/op_burn_mint_token_pool_mcms_test.go | Updates tests to use hex address strings and match StrToBytes encoding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnChangUK
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Describe highly relevant files or code snippets that are critical in the review
Are there other PRs that should be merged first?