Skip to content

fix token pool tooling - #482

Merged
FelixFan1992 merged 1 commit into
developfrom
fix-tp-tooling
Aug 3, 2026
Merged

fix token pool tooling#482
FelixFan1992 merged 1 commit into
developfrom
fix-tp-tooling

Conversation

@FelixFan1992

Copy link
Copy Markdown
Collaborator

Describe your changes

..

Issue ticket number and link

..

Describe highly relevant files or code snippets that are critical in the review

..

Are there other PRs that should be merged first?

..

@FelixFan1992
FelixFan1992 requested a review from Copilot August 1, 2026 21:52
@FelixFan1992
FelixFan1992 marked this pull request as ready for review August 1, 2026 21:52
@FelixFan1992
FelixFan1992 requested a review from a team as a code owner August 1, 2026 21:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CCIP token pool tooling by ensuring remote pool addresses are encoded as raw bytes derived from hex strings (instead of ASCII bytes), and by simplifying configuration sequences to rely on ApplyChainUpdates for remote pool additions.

Changes:

  • Convert RemotePoolAddress from hex string to []byte via deployment.StrToBytes when encoding AddRemotePool/RemoveRemotePool calls.
  • Remove redundant per-chain AddRemotePool execution from burn-mint and managed token pool configure sequences (remote pools are handled via ApplyChainUpdates).
  • Update MCMS proposal-data tests to use hex-formatted addresses and to mirror the new encoding logic.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
deployment/ops/ccip_managed_token_pool/seq_configure.go Removes per-chain remote pool add loop; relies on ApplyChainUpdates for remote pool configuration.
deployment/ops/ccip_managed_token_pool/op_managed_token_pool.go Uses StrToBytes for remote pool address encoding in add/remove remote pool ops.
deployment/ops/ccip_managed_token_pool/op_managed_token_pool_mcms_test.go Updates tests to use hex address strings and match StrToBytes encoding.
deployment/ops/ccip_lock_release_token_pool/op_lock_release_token_pool.go Uses StrToBytes for remote pool address encoding in add/remove remote pool ops.
deployment/ops/ccip_lock_release_token_pool/op_lock_release_token_pool_mcms_test.go Updates tests to use hex address strings and match StrToBytes encoding.
deployment/ops/ccip_burn_mint_token_pool/seq_configure.go Removes per-chain remote pool add loop; relies on ApplyChainUpdates for remote pool configuration.
deployment/ops/ccip_burn_mint_token_pool/op_burn_mint_token_pool.go Uses StrToBytes for remote pool address encoding in add remote pool op.
deployment/ops/ccip_burn_mint_token_pool/op_burn_mint_token_pool_mcms_test.go Updates tests to use hex address strings and match StrToBytes encoding.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FelixFan1992
FelixFan1992 merged commit d4d3e7e into develop Aug 3, 2026
74 of 75 checks passed
@FelixFan1992
FelixFan1992 deleted the fix-tp-tooling branch August 3, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants