Skip to content

Potential fixes for 2 code quality findings #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sebawo wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Draft

Potential fixes for 2 code quality findings #2705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6453f20
Apply suggested fix to seth/util.go from Copilot Autofix
sebawo Jul 21, 2026
3673682
Apply suggested fix to seth/util.go from Copilot Autofix
sebawo Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions seth/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func NewEphemeralKeys(addrs int64) ([]string, error) {
}

// CalculateSubKeyFunding calculates all required params to split funds from the root key to N test keys
func (m *Client) CalculateSubKeyFunding(addrs, gasPrice, rooKeyBuffer int64) (*FundingDetails, error) {
func (m *Client) CalculateSubKeyFunding(addrs, gasPrice, rootKeyBuffer int64) (*FundingDetails, error) {
if err := m.validateAddressesKeyNum(0); err != nil {
return nil, err
}
Expand All @@ -68,14 +68,14 @@ func (m *Client) CalculateSubKeyFunding(addrs, gasPrice, rooKeyBuffer int64) (*F

networkTransferFee := gasPrice * gasLimit
totalFee := new(big.Int).Mul(big.NewInt(networkTransferFee), big.NewInt(addrs))
rootKeyBuffer := new(big.Int).Mul(big.NewInt(rooKeyBuffer), big.NewInt(1_000_000_000_000_000_000))
freeBalance := new(big.Int).Sub(balance, big.NewInt(0).Add(totalFee, rootKeyBuffer))
rootKeyBufferWei := new(big.Int).Mul(big.NewInt(rootKeyBuffer), big.NewInt(1_000_000_000_000_000_000))
freeBalance := new(big.Int).Sub(balance, big.NewInt(0).Add(totalFee, rootKeyBufferWei))

L.Info().
Str("Balance (wei/ether)", fmt.Sprintf("%s/%s", balance.String(), WeiToEther(balance).Text('f', -1))).
Str("Total fee (wei/ether)", fmt.Sprintf("%s/%s", totalFee.String(), WeiToEther(totalFee).Text('f', -1))).
Str("Free Balance (wei/ether)", fmt.Sprintf("%s/%s", freeBalance.String(), WeiToEther(freeBalance).Text('f', -1))).
Str("Buffer (wei/ether)", fmt.Sprintf("%s/%s", rootKeyBuffer.String(), WeiToEther(rootKeyBuffer).Text('f', -1))).
Str("Buffer (wei/ether)", fmt.Sprintf("%s/%s", rootKeyBufferWei.String(), WeiToEther(rootKeyBufferWei).Text('f', -1))).
Msg("Root key balance")

if freeBalance.Cmp(big.NewInt(0)) < 0 {
Expand All @@ -88,9 +88,9 @@ func (m *Client) CalculateSubKeyFunding(addrs, gasPrice, rooKeyBuffer int64) (*F
" 2. Reduce number of ephemeral keys (current: %d)\n"+
" 3. Lower root_key_funds_buffer in config (current: %d ETH)",
balance.String(), WeiToEther(balance).Text('f', 6),
new(big.Int).Add(totalFee, rootKeyBuffer).String(), WeiToEther(new(big.Int).Add(totalFee, rootKeyBuffer)).Text('f', 6),
new(big.Int).Add(totalFee, rootKeyBufferWei).String(), WeiToEther(new(big.Int).Add(totalFee, rootKeyBufferWei)).Text('f', 6),
new(big.Int).Abs(freeBalance).String(), WeiToEther(new(big.Int).Abs(freeBalance)).Text('f', 6),
addrs, rooKeyBuffer)
addrs, rootKeyBuffer)
}

addrFunding := new(big.Int).Div(freeBalance, big.NewInt(addrs))
Expand All @@ -117,7 +117,7 @@ func (m *Client) CalculateSubKeyFunding(addrs, gasPrice, rooKeyBuffer int64) (*F
addrFunding.String(), WeiToEther(addrFunding).Text('f', 6),
WeiToEther(requiredBalance).Text('f', 6),
new(big.Int).Div(freeBalance, addrFunding).Int64(),
rooKeyBuffer)
rootKeyBuffer)
}

bd := &FundingDetails{
Expand Down
Loading