Pass pending calls limiter through engine#22623
Open
justinkaseman wants to merge 2 commits into
Open
Conversation
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
justinkaseman
force-pushed
the
feat/pending-calls-limiter
branch
from
69d778f to
fb25644
Compare
jmank88
approved these changes
May 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR updates Chainlink’s dependency set (primarily chainlink-common / chainlink-protos) and wires the newly introduced “pending calls” limiter through the workflow engine module configuration, aligning this repo with the referenced chainlink-common change.
Changes:
- Bump
github.com/smartcontractkit/chainlink-commonand related deps across modules (root, deployment, scripts, system/integration tests, devenv). - Pass
PendingCallsLimiterintohost.ModuleConfigfor workflow engine module instantiation. - Align
go.opentelemetry.io/contrib/bridges/prometheustov0.68.0where required.
Scrupulous human review areas:
core/services/workflows/syncer/v2/handler.golimiter mapping: confirm the chosen limiter (CapabilityConcurrency) is the intended limiter for “pending calls” in the updatedchainlink-commonhost runtime, and that it doesn’t unintentionally change effective concurrency semantics.- Dependency bumps to
chainlink-common/chainlink-protos: verify compatibility with the rest of the workflows engine stack and any transitive OTel dependency changes.
Reviewed changes
Copilot reviewed 9 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
core/services/workflows/syncer/v2/handler.go |
Wires PendingCallsLimiter into WASM host module config when creating workflow modules. |
go.mod / go.sum |
Bumps chainlink-common, chainlink-protos/cre/go, adds indirect OTel prometheus bridge requirement. |
deployment/go.mod / deployment/go.sum |
Keeps deployment module aligned with updated chainlink-common and OTel bridge versions. |
core/scripts/go.mod / core/scripts/go.sum |
Keeps scripts module aligned with updated chainlink-common and OTel bridge versions. |
system-tests/lib/go.mod / system-tests/lib/go.sum |
Keeps system-tests lib module aligned with updated deps. |
system-tests/tests/go.mod / system-tests/tests/go.sum |
Keeps system-tests tests module aligned with updated deps and OTel bridge. |
integration-tests/go.mod / integration-tests/go.sum |
Keeps integration-tests module aligned with updated deps and OTel bridge. |
integration-tests/load/go.mod / integration-tests/load/go.sum |
Keeps load tests module aligned with updated deps and bumps OTel bridge to v0.68.0. |
devenv/go.mod / devenv/go.sum |
Aligns devenv deps with updated chainlink-common; introduces Stellar indirect deps and related sums. |
Comment on lines
698
to
702
| MaxCompressedBinaryLimiter: h.engineLimiters.WASMCompressedBinarySize, | ||
| MaxDecompressedBinaryLimiter: h.engineLimiters.WASMBinarySize, | ||
| MaxResponseSizeLimiter: h.engineLimiters.ExecutionResponse, | ||
| PendingCallsLimiter: h.engineLimiters.CapabilityConcurrency, | ||
| EnableUserMetricsLimiter: h.engineLimiters.UserMetricEnabled, |
Comment on lines
+43
to
+46
| require ( | ||
| github.com/stellar/go-stellar-sdk v0.5.0 // indirect | ||
| github.com/stellar/go-xdr v0.0.0-20260312225820-cc2b0611aabf // indirect | ||
| ) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other side of smartcontractkit/chainlink-common#2074