Update libocr to metrics alpha branch#8454
Closed
reductionista wants to merge 15 commits into
Closed
Conversation
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
51530c3 to
d6bb2e3
Compare
Contributor
Author
|
Looks like in order to import this version without crashing, there needs to be a non-nil |
Contributor
Yes! That's how libocr will pass the metrics out to the Chainlink node's metrics stack. |
23d6d76 to
86cb48e
Compare
george-dorin
previously approved these changes
Mar 15, 2023
b5a41b9 to
2746275
Compare
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


See:
https://github.com/smartcontractkit/libocr/tree/copy-48c34f5b9a4bdcd6441084c048a95053972b9f80
When enabled, this should allow tracking of these metrics: