Skip to content

Update libocr to metrics alpha branch#8454

Closed
reductionista wants to merge 15 commits into
developfrom
libocr_metrics
Closed

Update libocr to metrics alpha branch#8454
reductionista wants to merge 15 commits into
developfrom
libocr_metrics

Conversation

@reductionista
Copy link
Copy Markdown
Contributor

See:
https://github.com/smartcontractkit/libocr/tree/copy-48c34f5b9a4bdcd6441084c048a95053972b9f80

When enabled, this should allow tracking of these metrics:

ragedisco_peers_count
ragedisco_peers_undiscovered
ragedisco_peers_discovered

@reductionista reductionista requested a review from a team as a code owner February 16, 2023 06:57
@github-actions
Copy link
Copy Markdown
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@reductionista
Copy link
Copy Markdown
Contributor Author

Looks like in order to import this version without crashing, there needs to be a non-nil Metrics field included in the PeerConfig object passed toocrnetworking.NewPeer()

@kaleofduty
Copy link
Copy Markdown
Contributor

Looks like in order to import this version without crashing, there needs to be a non-nil Metrics field included in the PeerConfig object passed toocrnetworking.NewPeer()

Yes! That's how libocr will pass the metrics out to the Chainlink node's metrics stack.

@krehermann krehermann requested a review from george-dorin March 15, 2023 13:17
george-dorin
george-dorin previously approved these changes Mar 15, 2023
@cl-sonarqube-production
Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition 32.7% 32.7% Coverage on New Code (is less than 90%)

See analysis details on SonarQube

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label May 22, 2023
@github-actions github-actions Bot closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants