feat: add changeset and operation to delete CRE workflow#54
Merged
Conversation
|
👋 karen-stepanyan, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
karen-stepanyan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CRE workflow deletion capability to the cld-changesets CRE tooling, mirroring the existing deploy flow but invoking the CRE CLI workflow delete command.
Changes:
- Introduces
CREWorkflowDeleteOpoperation that generatesworkflow.yaml/context.yaml, resolvesproject.yaml, and runscre workflow delete. - Adds
CREWorkflowDeleteChangesetto wire the delete operation into the deployments framework environment/config loading. - Adds unit tests for both the operation and changeset (CLI args, target forwarding, exit error propagation, and on-chain env injection).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cre/operations/workflow_delete.go |
New operation + input/output types for invoking cre workflow delete. |
cre/operations/workflow_delete_test.go |
Tests for delete operation CLI invocation, target forwarding, and exit error handling. |
cre/changesets/workflow_delete.go |
New changeset that validates environment/input and runs the delete operation with loaded env config. |
cre/changesets/workflow_delete_test.go |
Tests for changeset preconditions and Apply behavior (including on-chain env injection). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+42
to
+50
| // Validate trims fields and checks required workflow delete inputs. | ||
| func (in *CREWorkflowDeleteInput) Validate() error { | ||
| if in == nil { | ||
| return errors.New("cre workflow delete input is nil") | ||
| } | ||
| in.WorkflowName = strings.TrimSpace(in.WorkflowName) | ||
| in.DonFamily = strings.TrimSpace(in.DonFamily) | ||
| in.DeploymentRegistry = strings.TrimSpace(in.DeploymentRegistry) | ||
| if in.WorkflowName == "" { |
ecPablo
approved these changes
May 13, 2026
ecPablo
pushed a commit
that referenced
this pull request
May 18, 2026
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.0...v0.4.0) (2026-05-18) ### Features * add changeset and operation to delete CRE workflow ([#54](#54)) ([f0e341a](f0e341a)) * add support for multiple api key to deploy workflow ([#55](#55)) ([a68f156](a68f156)) * transfer native ([#56](#56)) ([4368e49](4368e49)) ### Bug Fixes * use cache dir for sol programs loading ([#52](#52)) ([b04f4d9](b04f4d9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty much the same workflow deploy but does not use binary or config options and executes CRE CLI
deletecommand.Tested locally and deleted a workflow on staging
https://smartcontract-it.atlassian.net/browse/DF-24747