Skip to content

Support longer/multiline changelog messages and fix package selection indent - #15

Merged
chainchad merged 3 commits into
mainfrom
dx-4853/multiline-changelog-msg
Jul 24, 2026
Merged

Support longer/multiline changelog messages and fix package selection indent#15
chainchad merged 3 commits into
mainfrom
dx-4853/multiline-changelog-msg

Conversation

@chainchad

Copy link
Copy Markdown
Collaborator

No description provided.

@chainchad
chainchad force-pushed the dx-4853/multiline-changelog-msg branch from 3fd758f to 6a6164a Compare July 24, 2026 17:59
@chainchad
chainchad force-pushed the dx-4853/multiline-changelog-msg branch from 6a6164a to 532a35a Compare July 24, 2026 18:01
@chainchad
chainchad marked this pull request as ready for review July 24, 2026 18:01
@chainchad
chainchad requested a review from a team as a code owner July 24, 2026 18:01
Copilot AI review requested due to automatic review settings July 24, 2026 18:01
kalverra
kalverra previously approved these changes Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the terminal UI flow for creating changesets to support longer, multi-line changelog messages, and improves the visual indentation of package rows when packages are grouped under section headers.

Changes:

  • Replaced single-line textinput with multi-line textarea for changelog entry input (confirm via ctrl+d, enter inserts newline), including resize-aware sizing.
  • Adjusted rendering of grouped package rows to be indented under their section header.
  • Added a test to validate multi-line summary entry and confirmation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/tui/tui.go Switch summary input to textarea, add dynamic height/width behavior, update confirmation key, and indent grouped package rows.
internal/tui/tui_test.go Adds coverage for multi-line summary input and ctrl+d confirmation.
.changeset/bright-clams-fly.md Records the user-facing change in the release notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .changeset/bright-clams-fly.md Outdated
Copilot AI review requested due to automatic review settings July 24, 2026 18:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

internal/tui/tui.go:431

  • Same return-evaluation-order issue here: return m, m.textArea.Focus() can drop the focus state change from the returned model if Focus() mutates the textarea model.
					m.assignRemainingAsPatch()
					m.state = StateEnterSummary
					return m, m.textArea.Focus()
				}

internal/tui/tui.go:437

  • Same return-evaluation-order issue here: return m, m.textArea.Focus() can return a model that is still blurred even though Focus() was called.
				// After minor step, assign remaining packages as patch
				m.assignRemainingAsPatch()
				m.state = StateEnterSummary
				return m, m.textArea.Focus()
			}

Comment thread internal/tui/tui.go
Comment thread internal/tui/tui.go
@chainchad
chainchad marked this pull request as draft July 24, 2026 18:14
@chainchad
chainchad marked this pull request as ready for review July 24, 2026 18:23
@chainchad
chainchad requested review from Copilot and kalverra July 24, 2026 18:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

@chainchad
chainchad merged commit d7c070b into main Jul 24, 2026
11 checks passed
@chainchad
chainchad deleted the dx-4853/multiline-changelog-msg branch July 24, 2026 19:13
@app-token-issuer-devex app-token-issuer-devex Bot mentioned this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants