Support longer/multiline changelog messages and fix package selection indent - #15
Merged
Conversation
chainchad
force-pushed
the
dx-4853/multiline-changelog-msg
branch
from
July 24, 2026 17:59
3fd758f to
6a6164a
Compare
chainchad
force-pushed
the
dx-4853/multiline-changelog-msg
branch
from
July 24, 2026 18:01
6a6164a to
532a35a
Compare
chainchad
marked this pull request as ready for review
July 24, 2026 18:01
kalverra
previously approved these changes
Jul 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the terminal UI flow for creating changesets to support longer, multi-line changelog messages, and improves the visual indentation of package rows when packages are grouped under section headers.
Changes:
- Replaced single-line
textinputwith multi-linetextareafor changelog entry input (confirm viactrl+d,enterinserts newline), including resize-aware sizing. - Adjusted rendering of grouped package rows to be indented under their section header.
- Added a test to validate multi-line summary entry and confirmation behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/tui/tui.go | Switch summary input to textarea, add dynamic height/width behavior, update confirmation key, and indent grouped package rows. |
| internal/tui/tui_test.go | Adds coverage for multi-line summary input and ctrl+d confirmation. |
| .changeset/bright-clams-fly.md | Records the user-facing change in the release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
internal/tui/tui.go:431
- Same return-evaluation-order issue here:
return m, m.textArea.Focus()can drop the focus state change from the returned model ifFocus()mutates the textarea model.
m.assignRemainingAsPatch()
m.state = StateEnterSummary
return m, m.textArea.Focus()
}
internal/tui/tui.go:437
- Same return-evaluation-order issue here:
return m, m.textArea.Focus()can return a model that is still blurred even thoughFocus()was called.
// After minor step, assign remaining packages as patch
m.assignRemainingAsPatch()
m.state = StateEnterSummary
return m, m.textArea.Focus()
}
chainchad
marked this pull request as draft
July 24, 2026 18:14
kalverra
approved these changes
Jul 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.