Skip to content

Add timeout error classification #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamRemis merged 13 commits into from
Nov 19, 2025
Merged

Add timeout error classification #590

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
24078a0
Add error classification
SamRemis Oct 24, 2025
bba7c15
pyright updates
SamRemis Oct 28, 2025
070ae4e
Add new required method to codegen
SamRemis Oct 28, 2025
af1dd5f
Updates from feedback
SamRemis Nov 5, 2025
d3a69bd
Remove fault from ClientErrorInfo
SamRemis Nov 5, 2025
50fce88
Remove outdated/incorrect docstrings
SamRemis Nov 5, 2025
c33e610
CI fixes
SamRemis Nov 5, 2025
391f85b
Make get_error_info optional
SamRemis Nov 12, 2025
4992388
Updates based on feedback
SamRemis Nov 13, 2025
5f62e6b
Add logic for handling timeouts to StandardRetryStrategy
SamRemis Nov 18, 2025
22ae90a
Apply suggestions from code review
SamRemis Nov 19, 2025
dae15d0
Updates from feedback
SamRemis Nov 19, 2025
bd022a6
Update mockhttp.py
SamRemis Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Alessandra Romero <24320222+alexgromero@users.noreply.github.com>
  • Loading branch information
@SamRemis @alexgromero
SamRemis and alexgromero authored Nov 19, 2025
commit 22ae90aebe02a5c9d35f55143b7468679c892107
2 changes: 1 addition & 1 deletion packages/smithy-core/src/smithy_core/retries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def acquire(self, *, error: Exception) -> int:
Otherwise, return the amount of capacity successfully allocated.
"""

is_timeout = getattr(error, "is_timeout_error", False)
is_timeout = isinstance(error, retries_interface.ErrorRetryInfo) and error.is_timeout_error
capacity_amount = self.TIMEOUT_RETRY_COST if is_timeout else self.RETRY_COST

with self._lock:
Expand Down
Loading