Merged
Conversation
mathics/builtin/image.py
Outdated
|
|
||
| def apply_no_image(self, array, evaluation): | ||
| 'ImageQ[Image[array_]]' | ||
| return Symbol('False') |
Owner
There was a problem hiding this comment.
What happens when the argument doesn't match either pattern? I think a better way would be to inherit from Test and implement the test as isinstance(arg, Image)
Author
There was a problem hiding this comment.
That's more elegant in any case, I changed that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid
ImageCreate[]and adds a real constructor rule toImage[], which means that under any circumstances anImage[]is now always anImage[](which makesImageQ[]possible, also included).Adds support for classic Mathics branch (even though we're not on it, I'm aware, but with the change in Mathics.js the image class works there now perfectly and I now wonder if the whole image thing belongs there really, as the JavaScript processing there and in the future Jupyter notebook will be identical).
I also had an implementation for DominantColors[], but it needs
scipy.spatial.KDTree, and I read the Google Groups link regarding scipy and your position on it. I'll try to sketch my position on this in a separate email.