EIP-7951: Precompile for secp256r1 Curve Support

[snissn]

No description provided.

[Copilot]

Pull request overview

This PR implements RIP-7212 secp256r1 curve precompile support and enables data activation notifications to EVM contracts. Note: The PR title mentions "EIP-7951" but the implementation is actually for RIP-7212.

Key changes:

• Adds RIP-7212 secp256r1 signature verification precompile at address 0x0100
• Removes restriction limiting data activation notifications to only the storage market actor, enabling EVM contracts to receive sector content change notifications
• Updates version from 16.0.1 to 17.0.0 (breaking change)

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
actors/evm/src/interpreter/precompiles/secp256r1.rs	New RIP-7212 precompile implementation with signature verification
actors/evm/src/interpreter/precompiles/mod.rs	Registers secp256r1 precompile at address 0x0100
actors/evm/tests/rip7212_precompile.rs	Assembly-level tests for precompile functionality
actors/evm/tests/basic.rs	Solidity contract tests for secp256r1 verification
actors/evm/tests/contracts/Secp256r1Precompile.sol	Test contract covering valid/invalid signature scenarios
actors/evm/tests/contracts/Secp256r1Precompile.hex	Compiled bytecode for test contract
actors/miner/src/notifications.rs	Removes market-only restriction for data activation notifications
integration_tests/src/tests/evm_notification_test.rs	Tests EVM contracts receiving sector notifications
test_vm/tests/suite/evm_notification_test.rs	Integration test wrappers
actors/evm/tests/contracts/NotificationReceiver.sol	Example notification receiver contract with CBOR parsing
actors/evm/tests/contracts/NotificationReceiver.hex	Compiled notification receiver bytecode
runtime/src/util/mapmap.rs	Fixes PhantomData import to use std::marker
actors/evm/Cargo.toml	Adds p256, alloy-core, and rstest dependencies
Cargo.toml	Updates version to 17.0.0 and relaxes serde version constraint
Cargo.lock	Updates dependencies including syn, serde, and new crates
test_vm/tests/suite/mod.rs	Registers new notification test module
integration_tests/src/tests/mod.rs	Exports notification test functions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This assertion is redundant and meaningless. It will always pass since result.is_empty() || !result.is_empty() is always true. Consider asserting on specific expected outcomes or removing this assertion entirely.

[Copilot]

This assertion is redundant and meaningless. It will always pass since result.is_empty() || !result.is_empty() is always true. The test should verify that invalid inputs are rejected properly, either by checking for specific error behavior or verifying the result is empty.

Suggested change

	assert!(result.is_empty() || !result.is_empty(), "{} should complete successfully", name);
	assert!(result.is_empty(), "{} should fail and return no output", name);

[Copilot]

The PR title mentions "EIP-7951" but the implementation is for "RIP-7212" (as correctly documented in the code). The PR title appears to have an incorrect EIP number.

[Copilot]

The array literal comparison could be error-prone. Consider using a constant for the precompile address (e.g., const RIP7212_PRECOMPILE_ADDRESS: [u8; 20] = [0x00, ..., 0x01, 0x00];) to ensure consistency with the lookup_precompile function and improve maintainability.

[Copilot]

The address checking logic uses different approaches in is_reserved_precompile_address (full array comparison) and lookup_precompile (byte-by-byte comparison). These should use the same logic or share a constant to prevent potential inconsistencies.

[Copilot]

The variable _evm_eth_addr is declared but never used. Either remove this variable or use it if it was intended for validation purposes.

Suggested change

let _evm_eth_addr = create_return.eth_address;

[Copilot]

The comment says "Empty proofs for testing" but the proofs are not actually empty - they contain vec![8, 8, 8, 8]. Update the comment to accurately describe the dummy proof values.

Suggested change

	sector_proofs: proofs, // Empty proofs for testing
	sector_proofs: proofs, // Dummy proofs for testing (vec![8, 8, 8, 8])

[Copilot]

The variable _method_selector is declared but never used. Either remove this variable or use it if it was intended for validation.

Suggested change

let _method_selector = NotificationReceiver::handle_filecoin_methodCall::SELECTOR;

[github-actions]

Suggested tag: v17.0.0

Comparing to: v16.0.1 (diff)

Changes in configuration file(s):

diff --git a/Cargo.toml b/Cargo.toml
index 06192549..949fc932 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,5 +1,5 @@
 [workspace]
-resolver = "2"
+resolver = "3"
 members = [
      "actors/*",
      "state",
@@ -12,7 +12,7 @@ members = [
 [workspace.package]
 version = "16.0.1"
 license = "MIT OR Apache-2.0"
-edition = "2021"
+edition = "2024"
 repository = "https://github.com/filecoin-project/builtin-actors"
 
 [package]
@@ -48,13 +48,13 @@ fil_actor_system = { workspace = true, features = ["fil-actor"] }
 fil_actor_verifreg = { workspace = true, features = ["fil-actor"] }
 
 [build-dependencies]
-fil_actor_bundler = "7.1.0"
+fil_actor_bundler = "8.0.0"
 cid = { workspace = true }
 fil_actors_runtime = { workspace = true }
 num-traits = { workspace = true }
 
 [dependencies]
-clap = { version = "4.3.0", features = [
+clap = { version = "4.5.36", features = [
      "derive",
      "std",
      "help",
@@ -74,43 +74,43 @@ testing-fake-proofs = []
 
 [workspace.dependencies]
 # Common
-serde = { version = "1.0.136", features = ["derive"] }
-anyhow = "1.0.65"
-bitflags = "2.4.0"
+serde = { version = "1.0.219", features = ["derive"] }
+anyhow = "1.0.98"
+bitflags = "2.9.0"
 num = { version = "0.4", features = ["serde"] }
 num-derive = "0.4.2"
-num-traits = "0.2.14"
-lazy_static = "1.4.0"
-log = { version = "0.4.14", features = ["std"] }
-byteorder = "1.4.3"
-itertools = "0.13.0"
-indexmap = { version = "2.7.0" }
+num-traits = "0.2.19"
+lazy_static = "1.5.0"
+log = { version = "0.4.27", features = ["std"] }
+byteorder = "1.5.0"
+itertools = "0.14.0"
+indexmap = { version = "2.9.0" }
 derive_builder = "0.20.2"
-once_cell = "1.17.0"
+once_cell = "1.21.3"
 rand = { version = "0.8.5", default-features = false }
 hex = "0.4.3"
-hex-literal = "0.4.1"
+hex-literal = "1.0.0"
 serde_json = "1.0"
 regex = "1"
 test-case = "3.3.1"
-bimap = "0.6.2"
-castaway = "0.2.2"
-thiserror = "1.0.30"
+bimap = "0.6.3"
+castaway = "0.2.3"
+thiserror = "2.0.12"
 pretty_env_logger = "0.5.0"
-serde_repr = "0.1.8"
+serde_repr = "0.1.20"
 unsigned-varint = "0.8.0"
 rand_chacha = "0.3.1"
 
 # Crypto
-libsecp256k1 = { version = "0.7.1", default-features = false }
+k256 = { version = "0.13.4", default-features = false }
 blake2b_simd = "1.0"
 sha2 = "0.10"
 
 # EVM
-alloy-core = { version = "0.8.19", default-features = false, features = ["sol-types"] }
-uint = { version = "0.9.3", default-features = false }
+alloy-core = { version = "1.0.0", default-features = false, features = ["sol-types"] }
+uint = { version = "0.10.0", default-features = false }
 etk-asm = "^0.3.0"
-rlp = { version = "0.5.1", default-features = false }
+rlp = { version = "0.6.1", default-features = false }
 substrate-bn = { version = "0.6.0", default-features = false }
 
 # IPLD/Encoding
@@ -118,26 +118,26 @@ cid = { version = "0.11.1", default-features = false, features = [
      "serde",
      "std",
 ] }
-multihash = { version = "0.19.1", default-features = false }
+multihash = { version = "0.19.3", default-features = false }
 multihash-codetable = { version = "0.1.4", default-features = false }
 multihash-derive = { version = "0.9.1", default-features = false }
-ipld-core = { version = "0.4.1", features = ["serde"] }
+ipld-core = { version = "0.4.2", features = ["serde"] }
 integer-encoding = { version = "4.0.2", default-features = false }
 
 # actor-utils
-fvm_actor_utils = "13.0.0"
-frc42_dispatch = "9.0.0"
-frc46_token = "13.0.0"
+fvm_actor_utils = "14.0.0"
+frc42_dispatch = "10.0.0"
+frc46_token = "14.0.0"
 
 # FVM
-fvm_sdk = "4.6.0"
-fvm_shared = "4.6.0"
-fvm_ipld_encoding = "0.5.2"
-fvm_ipld_blockstore = "0.3.0"
-fvm_ipld_hamt = "0.10.2"
-fvm_ipld_kamt = "0.4.4"
-fvm_ipld_amt = { version = "0.7.3" }
-fvm_ipld_bitfield = "0.7.0"
+fvm_sdk = "~4.7"
+fvm_shared = "~4.7"
+fvm_ipld_encoding = "0.5.3"
+fvm_ipld_blockstore = "0.3.1"
+fvm_ipld_hamt = "0.10.4"
+fvm_ipld_kamt = "0.4.5"
+fvm_ipld_amt = "0.7.4"
+fvm_ipld_bitfield = "0.7.2"
 
 # workspace
 fil_actor_account = { path = "actors/account" }diff --git a/actors/evm/Cargo.toml b/actors/evm/Cargo.toml
index d0b9c4ac..de100f92 100644
--- a/actors/evm/Cargo.toml
+++ b/actors/evm/Cargo.toml
@@ -33,6 +33,7 @@ hex = { workspace = true }
 hex-literal = { workspace = true }
 substrate-bn = { workspace = true }
 thiserror = { workspace = true }
+blst = "0.3.14"
 
 [dev-dependencies]
 hex = { workspace = true, features = ["serde"] }
diff --git a/integration_tests/Cargo.toml b/integration_tests/Cargo.toml
index ea665eb1..6c0b8498 100644
--- a/integration_tests/Cargo.toml
+++ b/integration_tests/Cargo.toml
@@ -4,7 +4,7 @@ description = "Portable integration tests for FVM targets"
 version = "1.0.0"
 license = "MIT OR Apache-2.0"
 authors = ["Protocol Labs", "Filecoin Core Devs"]
-edition = "2021"
+edition.workspace = true
 keywords = ["filecoin", "web3", "wasm"]
 publish = false
 
@@ -12,7 +12,7 @@ publish = false
 
 [dependencies]
 fil_builtin_actors_state = { workspace = true }
-fil_actors_runtime = { workspace = true, features = [ "test_utils" ] }
+fil_actors_runtime = { workspace = true, features = ["test_utils"] }
 fil_actor_init = { workspace = true }
 fil_actor_cron = { workspace = true }
 fil_actor_system = { workspace = true }
@@ -45,7 +45,7 @@ fvm_ipld_encoding = { workspace = true }
 fvm_ipld_hamt = { workspace = true }
 fvm_shared = { workspace = true }
 hex = { workspace = true }
-hex-literal = { workspace = true } 
+hex-literal = { workspace = true }
 indexmap = { workspace = true }
 integer-encoding = { workspace = true }
 lazy_static = { workspace = true }
@@ -57,9 +57,9 @@ rand_chacha = { workspace = true }
 regex = { workspace = true }
 serde = { workspace = true }
 thiserror = { workspace = true }
-libsecp256k1 = { workspace = true }
+k256 = { workspace = true, features = ["ecdsa"] }
 export_macro = { path = "./macro" }
-ctor = "0.2.5"
+ctor = "0.4.1"
 multihash-codetable = { workspace = true }
 
 [dev-dependencies]
diff --git a/integration_tests/macro/Cargo.toml b/integration_tests/macro/Cargo.toml
index dd44e0ea..32db42e7 100644
--- a/integration_tests/macro/Cargo.toml
+++ b/integration_tests/macro/Cargo.toml
@@ -3,13 +3,13 @@ name = "export_macro"
 description = "Macro to decorate integration tests"
 version = "1.0.0"
 license = "MIT OR Apache-2.0"
-edition = "2021"
+edition.workspace = true
 publish = false
 
 [lib]
 proc-macro = true
 
 [dependencies]
-syn = "2.0.38"
-quote = "1.0.33"
-proc-macro2 = "1.0.69"
\ No newline at end of file
+syn = "2.0.100"
+quote = "1.0.40"
+proc-macro2 = "1.0.94"
diff --git a/runtime/Cargo.toml b/runtime/Cargo.toml
index fd2e3de2..3e4e791f 100644
--- a/runtime/Cargo.toml
+++ b/runtime/Cargo.toml
@@ -45,9 +45,9 @@ pretty_env_logger = { workspace = true, optional = true }
 rand = { workspace = true, optional = true }
 multihash-derive = { workspace = true, optional = true }
 
-[dependencies.libsecp256k1]
+[dependencies.k256]
 workspace = true
-features = ["static-context", "std"]
+features = ["ecdsa"]
 optional = true
 
 [dev-dependencies]
@@ -95,4 +95,4 @@ no-provider-deal-collateral = []
 fake-proofs = []
 
 
-test_utils = ["hex", "multihash-derive", "multihash-codetable/sha2", "multihash-codetable/sha3", "multihash-codetable/ripemd", "libsecp256k1", "blake2b_simd", "rand", "rand/std_rng", "pretty_env_logger"]
+test_utils = ["hex", "multihash-derive", "multihash-codetable/sha2", "multihash-codetable/sha3", "multihash-codetable/ripemd", "k256", "blake2b_simd", "rand", "rand/std_rng", "pretty_env_logger"]
diff --git a/vm_api/Cargo.toml b/vm_api/Cargo.toml
index 29cadc0b..e6a88952 100644
--- a/vm_api/Cargo.toml
+++ b/vm_api/Cargo.toml
@@ -4,7 +4,7 @@ description = "Abstract virtual machine interface used for testing FVM native wa
 version = "1.0.0"
 license = "MIT OR Apache-2.0"
 authors = ["Protocol Labs", "Filecoin Core Devs"]
-edition = "2021"
+edition.workspace = true
 keywords = ["filecoin", "web3", "wasm"]
 publish = false
 

Cutting a Release (and modifying code files)

This PR is modifying both Cargo.toml and code files (not markdown, YAML, TOML or lock files).
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

Pre-creating GitHub Releases on release PRs initiated from forks is not supported.
If you wish to prepare release notes yourself, you should create a draft GitHub Release for tag v17.0.0 manually.
The draft GitHub Release is going to be published when this PR is merged.
If you choose not to create a draft GitHub Release, a published GitHub Released is going to be created when this PR is merged.