Skip to content

Update example apps #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-pjafari merged 8 commits into from
Aug 30, 2024
Merged

Update example apps #13

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02ace27
add readme to data-mapping
sfc-gh-pjafari Aug 29, 2024
ccad651
add readme to external-access-integration
sfc-gh-pjafari Aug 29, 2024
a022e4a
remove create security integration from spcs
sfc-gh-pjafari Aug 29, 2024
85fa91e
add readme to spcs example
sfc-gh-pjafari Aug 29, 2024
addeebe
update ci.yml to handle no python tests in dir
sfc-gh-pjafari Aug 29, 2024
698e305
check ret
sfc-gh-pjafari Aug 29, 2024
5e3eef1
remove lowercase readme
sfc-gh-pjafari Aug 29, 2024
1a63648
re-add README.md
sfc-gh-pjafari Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions data-mapping/app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Data Mapping

1 change: 1 addition & 0 deletions external-access-integration/app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# External Access Integration
1 change: 1 addition & 0 deletions external-access-integration/app/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ artifacts:
setup_script: setup_script.sql
default_streamlit: core.ui
extension_code: true
readme: README.md

references:
- external_access_reference:
Expand Down
1 change: 1 addition & 0 deletions spcs-three-tier/app/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ configuration:

artifacts:
setup_script: setup.sql
readme: README.md

default_web_endpoint:
service: app_public.frontend
Expand Down
5 changes: 0 additions & 5 deletions spcs-three-tier/prepare/spcs_setup.sql
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion spcs-three-tier/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
set -e
snow sql -f "prepare/spcs_setup.sql"
Copy link

@sfc-gh-melnacouzi sfc-gh-melnacouzi Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this? Maybe some context would help.

Copy link
Contributor Author

@sfc-gh-pjafari sfc-gh-pjafari Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no longer needed. updated PR description with Jira ticket :)
https://snowflakecomputing.atlassian.net/browse/SNOW-1527720

snow sql -f "prepare/provider_setup.sql"
snow sql -f "prepare/consumer_setup.sql"

Expand Down