fix: improve typing of docker registry client#6837
Open
d3vco wants to merge 1 commit into
Open
Conversation
|
| Status | Scan Engine |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details | |
| Licenses | 0 | 0 | 0 | 0 | See details | |
| ✅ | Code Security | 0 | 0 | 0 | 0 | 0 issues |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Contributor
This comment has been minimized.
This comment has been minimized.
d3vco
changed the title
d3vco
changed the title
d3vco
force-pushed
the
chore/update-docker-registry-client
branch
from
3ea24c3 to
de43867
Compare
This comment has been minimized.
This comment has been minimized.
d3vco
force-pushed
the
chore/update-docker-registry-client
branch
2 times, most recently
from
f8e63a1 to
8ccff1a
Compare
d3vco
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d3vco
force-pushed
the
chore/update-docker-registry-client
branch
from
8ccff1a to
c190aef
Compare
Updates client options to use the new `ClientOptions` type and corrects an error in the `acceptLayer` option name. Replaces patches/needle+3.3.0.patch with patches/needle+3.5.0.patch to restore the resp.resume() redirect fix after needle was upgraded to 3.5.0 by @snyk/docker-registry-v2-client@4.0.2.
d3vco
force-pushed
the
chore/update-docker-registry-client
branch
from
c190aef to
7fe16ed
Compare
This comment has been minimized.
This comment has been minimized.
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Bumps
@snyk/docker-registry-v2-clientfrom^2.24.1to^4.0.2and adapts the registry client to use the typedClientOptions. This type check indicated a typo in theacceptLayeroption.The new client also bumps
needlefrom^3.3.0to^3.5.0. To make this change, the needle patch added here was regenerated for the new version.Where should the reviewer start?
src/cli/commands/test/iac/local-execution/rules/oci-registry.ts: only call-site change needed to accommodate the v4 client API.How should this be manually tested?
snyk iac testwith a custom rules bundle) and confirm rules are fetched successfully.What's the product update that needs to be communicated to CLI users?
No user-facing change, internal dependency update.
Risk assessment (Low | Medium | High)?
Low — dependency bump with a direct call-site adaptation. No logic changes; the patch preserves existing behaviour.
Any background context you want to provide?
See Jira ticket for more on the impetus for this version bump.
What are the relevant tickets?
Jira ticket