add fields resolved and integrity to deptree and depgraph#199
Closed
milahu wants to merge 4 commits into
Closed
Conversation
5 tasks
|
Your PR has not had any activity for 60 days. In 7 days I'll close it. Make some activity to remove this. |
|
Your PR has now been stale for 7 days. I'm closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
add fields
resolvedandintegrityto deptree and depgraphcontinue #112 by @abdulhannanali
commit 9dd6745 is based on 60853a7
i have added the new fields as
node.info.labels.resolvedandnode.info.labels.integrity, because@snyk/dep-graphallows to add custom string values to node.info.labelsNotes for the reviewer
probably this will not be merged, because snyk does not use
resolvedandintegrityvalues of lockfilesto me, the
resolvedandintegrityvalues are useful to build a custom npm package installer. for example usage, see milahu/pnpm-install-only@4278992, where i have both a tree-walker and a graph-walkermerged in https://github.com/milahu/nodejs-lockfile-parser