Retry remote HTTP/2 internal errors - #232
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
retry-remote-error
branch
4 times, most recently
from
July 29, 2026 05:34
3d97164 to
c450c45
Compare
samuel-williams-shopify
force-pushed
the
retry-remote-error
branch
from
July 29, 2026 05:35
c450c45 to
ad8284b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamError(INTERNAL_ERROR)toProtocol::HTTP::RemoteErrorwhile waiting for response headers.StreamError, including its HTTP/2 error code, asException#cause.RemoteErrorusingRequest#retry!, so only retry-safe methods with rewindable bodies are resent.protocol-http ~> 0.66forRemoteError.The translation occurs in
HTTP2::Client#read_response, where the protocol-specific response failure becomes the outcome of the abstract HTTP client call. This establishes the native cause chain without changing the low-level protocol-http2 callback lifecycle. Resets received after a response has already been returned remain visible while reading the response body and are not transparently retried.Closes #231.
Testing