Skip to content

Rework file structure & license header. - #89

Merged
ioquatix merged 4 commits into
mainfrom
rework-files
Jun 2, 2022
Merged

Rework file structure & license header.#89
ioquatix merged 4 commits into
mainfrom
rework-files

Conversation

@ioquatix

@ioquatix ioquatix commented Jun 2, 2022

Copy link
Copy Markdown
Member

Tidy up the file structure including require_relative where it makes sense.

Types of Changes

  • Maintenance.

Comment thread spec/spec_helper.rb Outdated
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>

@olleolleolle olleolleolle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good compatibility workout!

@ioquatix

ioquatix commented Jun 2, 2022

Copy link
Copy Markdown
Member Author

@olleolleolle I hope it's sufficient, this gem has a lot of downloads.

Comment thread spec/spec_helper.rb Outdated
@texpert

texpert commented Jun 9, 2022

Copy link
Copy Markdown

Excuse me, but why all these hardcoded warnings' noise in the logs now?

@ioquatix

ioquatix commented Jun 9, 2022

Copy link
Copy Markdown
Member Author

Because you updated the gem and we are emitting warnings for files that will eventually be removed because they are clobbering global namespace/paths.

@texpert

texpert commented Jun 9, 2022

Copy link
Copy Markdown

Because you updated the gem and we are emitting warnings for files that will eventually be removed because they are clobbering global namespace/paths.

I understand the primary reason, but then there was #91, where all these constants where deprecated via Object.deprecate_constant, so now the uncoditional warnings are just a bothering noise.

@ioquatix

ioquatix commented Jun 9, 2022

Copy link
Copy Markdown
Member Author

The files and the constants they define are two separate issues with separate warnings.

It sounds like you are suggesting to remove the explicit warnings from the files. It's probably better we just fix the dependencies. If you don't want to deal with the warnings, stay with the old versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants