Skip to content

Fix blank line indentation for modifier conditionals - #2

Merged
samuel-williams-shopify merged 2 commits into
mainfrom
fix-modifier-blank-line-indentation
Jul 29, 2026
Merged

Fix blank line indentation for modifier conditionals#2
samuel-williams-shopify merged 2 commits into
mainfrom
fix-modifier-blank-line-indentation

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • ignore modifier if/unless nodes when calculating structural indentation depth
  • add regression coverage for a guarded describe block
  • cover begin ... end while and begin ... end until, which parse as while_post/until_post and are already excluded from structural depth

Verification

  • bundle exec sus (117 passed, 157 assertions)
  • bundle exec rubocop (17 files, no offenses)
  • checked the original async-container/test/async/container/forked.rb through the patched plugin

@samuel-williams-shopify
samuel-williams-shopify merged commit d077949 into main Jul 29, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant