std::result::Result#31
Open
afeistel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Replaces
Resultwithstd::result::Resultin the derived code.Why: had errors because of
type Result<T> = std::result::Result<T, Error>(a common thing to do).We really should also prefix everything with
::at some point (::std::somethinginstead ofstd::something). For now, kept it consistent with existing code.How did you verify your change:
Ran tests (they passed), ran the example (it didn't error out), built the code where I needed that change made (it compiled correctly).
What (if anything) would need to be called out in the CHANGELOG for the next release: