added <pre> tag to table data to preserve new lines#19
added <pre> tag to table data to preserve new lines#19dhoomakethu wants to merge 1 commit intosoftvar:masterfrom
Conversation
|
Tests have failed and I think it's not necessary. Can you please add the screenshots, before and after the change? Would help a lot. |
|
I think in general the pre-tag may make sense, however this is the wrong way to do it IMO. With this implementation everything within a td, including sub tables, sub lists, sub objects, gets wrapped in a |
|
Oops, I raised the PR by mistake ,apologies for that.I was in a bit of hurry, so did not modified the tests, , I will update them as well. Just for the sake of clarification , here is the issue and how the pre tag solves the formatting. Without "pre" tag With "pre" tag I agree with @muellermichel 's comment ,this is a fast cooked solution solving my current problem, I probably shouldn't have had the PR raised , I will decline the PR . ----update---- Thank you. ---update2----- |
|
Please don't feel offended. Take your time. I really appreciate the patch.
|


I needed this features as my JSON had values with multiline string , with