Skip to content

feat: mentions with space - android#286

Merged
exploIF merged 3 commits into
mainfrom
@exploif/android-mentions-with-space
Nov 28, 2025
Merged

feat: mentions with space - android#286
exploIF merged 3 commits into
mainfrom
@exploif/android-mentions-with-space

Conversation

@exploIF

@exploIF exploIF commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator

Summary

This PR brings possibility to use mentions with one space inside it on Android platform.

Test Plan

Provide clear steps so another contributor can reproduce the behavior or verify the feature works.
For example:

  • run example app
  • enter @John Doe
  • notice that entering whitespace does not close mention selector

Screenshots / Videos

Screen.Recording.2025-11-27.at.13.20.26.mov

Compatibility

OS Implemented
iOS
Android

@exploIF exploIF marked this pull request as ready for review November 27, 2025 12:26
@szydlovsky

Copy link
Copy Markdown
Collaborator

Works mostly fine but I found one issue: sometimes we don't get on mention event where it definitely should be. See here on the recording; we start typing a mention, then write a second word, then come back with selection to the first one. It should definitely start editing again but it doesn't:

Screen.Recording.2025-11-27.at.14.09.54.mov

@szydlovsky szydlovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous comment I added can be skipped for now, since it stems from performance limitations on Android. Works as expected otherwise!

@exploIF

exploIF commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks for catching it, this is something that we should definitely consider improving in the future. It mostly comes from the fact that we are relying on text change, rather than on selection change. As it's not regression, and it's working exactly the same on current main branch, I will add it to our roadmap and we can think on it later

@kacperzolkiewski kacperzolkiewski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine. Nice work 👏

@exploIF exploIF merged commit e99fd6a into main Nov 28, 2025
5 checks passed
@exploIF exploIF deleted the @exploif/android-mentions-with-space branch November 28, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants