feat: make iOS mentions work with a single space#289
Merged
Conversation
exploIF
reviewed
Nov 27, 2025
exploIF
left a comment
exploIF
left a comment
Collaborator
There was a problem hiding this comment.
Agree with @kacperzolkiewski, functionally works well
exploIF
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes iOS mentions tolerate a single space.
Code responsible for detecting a currently edited mention would just take the current word into the account.
Now it works by trying to search for one more word before the current one if needed. This way all of the following scenarios will be detected as editable mention:
Effectively these scenarios are enough to achieve space tolerating mentions.
Test Plan
Open iOS example app and play with mentions and spaces.
Screenshots / Videos
Screen.Recording.2025-11-26.at.19.51.08.mov
Compatibility