fix(android): set piority of applied spans#629
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces span-flag priorities on Android so that inline spans are applied after paragraph spans, improving style override behavior (e.g., inline code inside blockquote).
Changes:
- Added a shared
EnrichedSpanFlagshelper to consistently applySPAN_PRIORITYbits for paragraph vs inline spans. - Updated multiple Android code paths (parser, text input, text view, style appliers, span re-application) to use these prioritized flags when setting spans.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| android/src/main/java/com/swmansion/enriched/textinput/utils/Utils.kt | Reapplies checkbox list spans using prioritized flags. |
| android/src/main/java/com/swmansion/enriched/textinput/utils/EnrichedSpannable.kt | Extends paragraph/block spans over pasted text using prioritized flags. |
| android/src/main/java/com/swmansion/enriched/textinput/styles/ParametrizedStyles.kt | Applies prioritized inline flags to link and mention spans. |
| android/src/main/java/com/swmansion/enriched/textinput/styles/ParagraphStyles.kt | Applies prioritized paragraph flags when setting paragraph spans. |
| android/src/main/java/com/swmansion/enriched/textinput/styles/ListStyles.kt | Applies prioritized paragraph flags to list-related spans. |
| android/src/main/java/com/swmansion/enriched/textinput/styles/InlineStyles.kt | Applies prioritized inline flags for inline styles. |
| android/src/main/java/com/swmansion/enriched/textinput/EnrichedTextInputView.kt | Preserves base flags while reapplying spans with computed priority. |
| android/src/main/java/com/swmansion/enriched/text/EnrichedTextView.kt | Preserves base flags while reapplying spans with computed priority. |
| android/src/main/java/com/swmansion/enriched/common/parser/EnrichedParser.java | Uses prioritized flags when applying inline/paragraph spans during HTML parsing. |
| android/src/main/java/com/swmansion/enriched/common/EnrichedSpanFlags.kt | New centralized helper for applying SPAN_PRIORITY bits to span flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
exploIF
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply priority to android spans that inline spans will be applied after paragraph spans.
See: https://stackoverflow.com/questions/46002947/how-to-define-order-setpriority-of-spannable-in-android
Test Plan
Play around with styles on android and check if inline styles override paragraph styles.
For example: Inline code inside blockquote.
Screenshots / Videos
Screen.Recording.2026-06-09.at.13.41.07.mov
Compatibility
Checklist