Skip to content

fix(android): set piority of applied spans#629

Merged
kacperzolkiewski merged 5 commits into
mainfrom
@kacperzolkiewski/android-span-priority
Jun 19, 2026
Merged

fix(android): set piority of applied spans#629
kacperzolkiewski merged 5 commits into
mainfrom
@kacperzolkiewski/android-span-priority

Conversation

@kacperzolkiewski

@kacperzolkiewski kacperzolkiewski commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Apply priority to android spans that inline spans will be applied after paragraph spans.
See: https://stackoverflow.com/questions/46002947/how-to-define-order-setpriority-of-spannable-in-android

Test Plan

Play around with styles on android and check if inline styles override paragraph styles.
For example: Inline code inside blockquote.

Screenshots / Videos

Screen.Recording.2026-06-09.at.13.41.07.mov

Compatibility

OS Implemented
iOS
Android

Checklist

  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

@kacperzolkiewski kacperzolkiewski marked this pull request as ready for review June 9, 2026 12:07
@kacperzolkiewski kacperzolkiewski requested a review from exploIF June 9, 2026 12:07
@exploIF exploIF requested a review from Copilot June 11, 2026 15:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces span-flag priorities on Android so that inline spans are applied after paragraph spans, improving style override behavior (e.g., inline code inside blockquote).

Changes:

  • Added a shared EnrichedSpanFlags helper to consistently apply SPAN_PRIORITY bits for paragraph vs inline spans.
  • Updated multiple Android code paths (parser, text input, text view, style appliers, span re-application) to use these prioritized flags when setting spans.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
android/src/main/java/com/swmansion/enriched/textinput/utils/Utils.kt Reapplies checkbox list spans using prioritized flags.
android/src/main/java/com/swmansion/enriched/textinput/utils/EnrichedSpannable.kt Extends paragraph/block spans over pasted text using prioritized flags.
android/src/main/java/com/swmansion/enriched/textinput/styles/ParametrizedStyles.kt Applies prioritized inline flags to link and mention spans.
android/src/main/java/com/swmansion/enriched/textinput/styles/ParagraphStyles.kt Applies prioritized paragraph flags when setting paragraph spans.
android/src/main/java/com/swmansion/enriched/textinput/styles/ListStyles.kt Applies prioritized paragraph flags to list-related spans.
android/src/main/java/com/swmansion/enriched/textinput/styles/InlineStyles.kt Applies prioritized inline flags for inline styles.
android/src/main/java/com/swmansion/enriched/textinput/EnrichedTextInputView.kt Preserves base flags while reapplying spans with computed priority.
android/src/main/java/com/swmansion/enriched/text/EnrichedTextView.kt Preserves base flags while reapplying spans with computed priority.
android/src/main/java/com/swmansion/enriched/common/parser/EnrichedParser.java Uses prioritized flags when applying inline/paragraph spans during HTML parsing.
android/src/main/java/com/swmansion/enriched/common/EnrichedSpanFlags.kt New centralized helper for applying SPAN_PRIORITY bits to span flags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread android/src/main/java/com/swmansion/enriched/common/parser/EnrichedParser.java Outdated

@exploIF exploIF left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread android/src/main/java/com/swmansion/enriched/common/parser/EnrichedParser.java Outdated
Comment thread android/src/main/java/com/swmansion/enriched/common/EnrichedSpanFlags.kt Outdated
@kacperzolkiewski kacperzolkiewski merged commit 77d0ee6 into main Jun 19, 2026
7 checks passed
@kacperzolkiewski kacperzolkiewski deleted the @kacperzolkiewski/android-span-priority branch June 19, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants