refactor(vad): store duration constants in ms instead of hops#1200
Merged
Conversation
kMinSpeechDuration, kMinSilenceDuration and kSpeechPad were stored as hop counts with trailing comments hinting the ms equivalent. The unit implicitly depended on kHopLengthMs, and the comments would rot if kHopLengthMs ever changed. Rename to *Ms and convert to hops at the use site by dividing by kHopLengthMs, matching the kWindowSizeMs / kHopLengthMs convention used elsewhere in the file. Closes #1172
benITo47
approved these changes
May 29, 2026
Contributor
benITo47
left a comment
benITo47
left a comment
There was a problem hiding this comment.
Keeping the code clean I see.
✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kMinSpeechDuration,kMinSilenceDurationandkSpeechPadwere stored as hop counts with trailing comments hinting the ms equivalent. The unit implicitly depended onkHopLengthMs, and the comments would rot the moment someone changed it.Rename to
*Msto match thekWindowSizeMs/kHopLengthMsconvention and convert to hops at the use site via/ kHopLengthMs. NowkHopLengthMschanges propagate automatically and the source-of-truth unit is explicit in the name.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Refactor only — values are unchanged (
250 / 10 = 25,100 / 10 = 10,30 / 10 = 3). Existing VAD behavior should be identical.Screenshots
Related issues
Closes #1172
Checklist
Additional notes
Per discussion in the issue, picked option 2 (ms-based source of truth) over the rename-with-
Hops-suffix option because it survives changes tokHopLengthMs.