Prop for ending pinching gesture when one finger is lifted (iOS)#1391
Closed
iqqmuT wants to merge 4 commits into
Closed
Prop for ending pinching gesture when one finger is lifted (iOS)#1391iqqmuT wants to merge 4 commits into
iqqmuT wants to merge 4 commits into
Conversation
iqqmuT
commented
Feb 28, 2021
| // user lifts one finger from the view. | ||
| if (_twoPointersRequired) { | ||
| self.state = UIGestureRecognizerStateEnded; | ||
| [self reset]; |
Author
There was a problem hiding this comment.
Not sure if calling reset is required.
Member
|
Closing this as we actually implemented the opposite in #2983 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1214.
Probably the maintainers don't want to alter the native iOS behavior with this PR, but this fork can be useful for those who want to avoid writing workarounds.
This fork adds a new boolean prop for PinchGestureHandler (iOS only): twoPointersRequired
false(default): no change for behavior; lets UIPinchGestureRecognizer end the gesture when the user lifts off both fingers from the viewtrue: end the gesture when the user lifts off one finger from the viewTest plan
Tested on iPhone 6s Plus.