fix: android - Pinch gesture handler when one finger is lifted#1799
Closed
intergalacticspacehighway wants to merge 2 commits intosoftware-mansion:mainfrom
Closed
Conversation
| if (event.actionMasked == MotionEvent.ACTION_POINTER_UP) { | ||
| activePointers -= 1 | ||
|
|
||
| if(event.actionMasked != MotionEvent.ACTION_POINTER_UP){ |
Author
There was a problem hiding this comment.
This surely appears weird, but I am not sure If there's a better way to achieve this. This is done due to the below scenario.
User has 2 fingers and performing pinch -> One finger is lifted -> ACTION_POINTER_UP is fired -> event.pointerCount is still 2 -> scale detector sets the focal values to single finger -> the event received has new focus but the pointer count is still 2.
However, this again makes it consistent with iOS. iOS Pinch handler doesn't send events in case of a finger is lifted. Only when a single pointer is moved, it starts sending the event. (practically tested, it would be great if someone can find it documented somewhere)
Author
|
Closing in favor of #1800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I agree with the notion of preserving the platform behaviour on iOS but in case of android there's no native pinch handler and some custom logic is already there in place, so I am not sure what behavior is correct. I am not sure whether this PR should be merged 😅
Approach
Test plan