Add modified ScaleGestureDetector from AOSP#1879
Merged
Merged
Conversation
j-piasecki
force-pushed
the
@jpiasecki/copy-scale-gesture-detector
branch
from
19b4d61 to
5fd610f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds modified
ScaleGestureDetectorfrom the Android Open Source Project. Main reason behind this is the fact that originallymMinSpanis set to 27mm which seems to be excessive. In the modified file I set this value to be 0 which is consistent with pinch behavior on iOS. PinchGestureDetector on Android now uses modified detector.Also includes
NOTICEfile from AOSP (android/platform/frameworks/base) in compliance with APACHE 2.0 license.Fixes #1811
Test plan
Tested on the Example app.