add buildconfig flag for AGP8+#2599
Merged
Merged
Conversation
Contributor
Author
|
Done |
m-bert
approved these changes
Sep 27, 2023
renovate Bot
referenced
this pull request
in valora-xyz/wallet
Oct 15, 2023
…4315) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler) | [`^2.13.1` -> `^2.13.2`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.13.1/2.13.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-gesture-handler (react-native-gesture-handler)</summary> ### [`v2.13.2`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.13.2) [Compare Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.13.1...2.13.2) #### 🐛 Bug fixes - Add `ghQueueMicrotask` by [@​m-bert](https://togithub.com/m-bert) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2612](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2612) #### 👍 Improvements - New onSwipeableOpenDragStart and onSwipeableCloseDragStart events by [@​rampazzo1989](https://togithub.com/rampazzo1989) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2589](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2589) - Remove jcenter by [@​ChaseKnowlden](https://togithub.com/ChaseKnowlden) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2610](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2610) - Add buildconfig flag for AGP8+ by [@​pvegh](https://togithub.com/pvegh) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2599](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2599) #### 🔢 Miscellaneous - Update dependencies in e2e/web-tests by [@​m-bert](https://togithub.com/m-bert) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2601](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2601) - Bump [@​sideway/formula](https://togithub.com/sideway/formula) from 3.0.0 to 3.0.1 in /FabricExample by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2605](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2605) - Bump [@​sideway/formula](https://togithub.com/sideway/formula) from 3.0.0 to 3.0.1 in /docs by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2602](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2602) - Give some love to Gesture Handler docs by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2607](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2607) - Fix typo in Composing gestures docs by [@​S1D007](https://togithub.com/S1D007) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2614](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2614) - Bump postcss from 8.4.30 to 8.4.31 in /e2e/web-tests by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2623](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2623) - Bump postcss from 8.4.14 to 8.4.31 in /docs by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2621](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2621) - Bump [@​sideway/formula](https://togithub.com/sideway/formula) from 3.0.0 to 3.0.1 in /example by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-gesture-handler/pull/2606](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2606) #### New Contributors - [@​rampazzo1989](https://togithub.com/rampazzo1989) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2589](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2589) - [@​ChaseKnowlden](https://togithub.com/ChaseKnowlden) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2610](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2610) - [@​pvegh](https://togithub.com/pvegh) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2599](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2599) - [@​S1D007](https://togithub.com/S1D007) made their first contribution in [https://github.com/software-mansion/react-native-gesture-handler/pull/2614](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2614) **Full Changelog**: software-mansion/react-native-gesture-handler@2.13.1...2.13.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for AGP8 by adding the buildConfig Flag indicating that this library uses custom buildconfig fields and needs it's BuildConfig class generated.
Fixes #2571
Test plan
No idea, need some help here since I'm not a RN person. I'm just trying to push support for AGP8 so we don't have to enable generating BuildConfig classes generally in our project, which has a performance impact.