Skip to content

Fix RNRenderer import for React Native 0.86+ #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 5 commits into from
May 11, 2026
Merged

Fix RNRenderer import for React Native 0.86+ #4160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ddb3e4d
Fix `RNRenderer` import for React Native 0.86+
zoontek May 8, 2026
0cffecf
Copilot review
zoontek May 8, 2026
0d48ca9
remove extra space
zoontek May 8, 2026
adcf1d0
use export const
zoontek May 8, 2026
9ce800d
Remove validateDetectorChildren
zoontek May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/react-native-gesture-handler/src/RNRenderer.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/react-native-gesture-handler/src/RNRenderer.web.ts
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions .../react-native-gesture-handler/src/handlers/gestures/GestureDetector/useDetectorUpdater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { dropHandlers } from './dropHandlers';
import { needsToReattach } from './needsToReattach';
import type { AttachedGestureState, GestureDetectorState } from './types';
import { updateHandlers } from './updateHandlers';
import { useForceRender, validateDetectorChildren } from './utils';
import { useForceRender } from './utils';

// Returns a function that's responsible for updating the attached gestures
// If the view has changed, it will reattach the handlers to the new view
Expand All @@ -34,7 +34,6 @@ export function useDetectorUpdater(
didUnderlyingViewChange ||
needsToReattach(preparedGesture, gesturesToAttach)
) {
validateDetectorChildren(state.viewRef);
dropHandlers(preparedGesture);
attachHandlers({
preparedGesture,
Expand Down
52 changes: 0 additions & 52 deletions packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { useCallback, useRef, useState } from 'react';
import { Platform } from 'react-native';

import { RNRenderer } from '../../../RNRenderer';
import { isTestEnv, tagMessage } from '../../../utils';
import type {
GestureHandlerNativeEvent,
Expand Down Expand Up @@ -124,56 +122,6 @@ export function checkGestureCallbacksForWorklets(gesture: GestureType) {
}
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
export function validateDetectorChildren(ref: any) {
// Finds the first native view under the Wrap component and traverses the fiber tree upwards
// to check whether there is more than one native view as a pseudo-direct child of GestureDetector
// i.e. this is not ok:
// Wrap
// |
// / \
// / \
// / \
// / \
// NativeView NativeView
//
// but this is fine:
// Wrap
// |
// NativeView
// |
// / \
// / \
// / \
// / \
// NativeView NativeView
if (__DEV__ && Platform.OS !== 'web') {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const wrapType =
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
ref._reactInternals.elementType;

// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
let instance =
RNRenderer.findHostInstance_DEPRECATED(
ref
)._internalFiberInstanceHandleDEV;

// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
while (instance && instance.elementType !== wrapType) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
if (instance.sibling) {
throw new Error(
'GestureDetector has more than one native view as its children. This can happen if you are using a custom component that renders multiple views, like React.Fragment. You should wrap content of GestureDetector with a <View> or <Animated.View>.'
);
}

// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
instance = instance.return;
}
}
}

export function useForceRender() {
const [renderState, setRenderState] = useState(false);
const forceRender = useCallback(() => {
Expand Down
Loading