fix: change default gesture from Tap to Fling, fix failing CI #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
changed the title
Co-authored-by: m-bert <michal.bert@swmansion.com>
WoLewicki
reviewed
Feb 1, 2024
| .toBeVisible() | ||
| .whileElement(by.id('root-screen-examples-scrollview')) | ||
| .scroll(200, 'down'); | ||
| .scroll(100, 'down', NaN, 0.85); |
Member
There was a problem hiding this comment.
What is the reason for changing this value?
Contributor
Author
There was a problem hiding this comment.
I see that on higher Android APIs with gestures as a device navigation, phone can accidentally go into the preview of apps in the background - that's why I've added the offset here
Member
|
Also, I am not sure I understand what is going on exactly. Why does gesture-handler call the |
Contributor
Author
|
@WoLewicki we're not testing them, but this change does not only limit to the case of the CI. Because of the default |
Member
|
Ok keep me updated 🚀 |
shottah
referenced
this pull request
in Kolektivo/Kolektivo-Mobile-App
May 15, 2024
…xyz#5239) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://togithub.com/software-mansion/react-native-screens) | [`^3.29.0` -> `^3.30.1`](https://renovatebot.com/diffs/npm/react-native-screens/3.29.0/3.30.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.30.1`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.30.1) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.30.0...3.30.1) Patch release addressing an issue with building a package due to the missing submodule from `postinstall` command. #### 🔢 Miscellaneous - Remove postinstall step from package.json by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2081](https://togithub.com/software-mansion/react-native-screens/pull/2081) **Full Changelog**: software-mansion/react-native-screens@3.30.0...3.30.1 ### [`v3.30.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.30.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.29.0...3.30.0) Minor release including custom screen transitions, adding support for VisionOS, supporting `slide_from_left` animation on iOS and fixing other aspects (including wrong targets for touchable components on Fabric). Thanks for following along! 💙 **Note**: Please note that support for React Native versions lower than 0.68 have been **dropped**. Older versions may still continue to work with this and newer releases of react-native-screens, but bugs from deprecated versions will not be considered for repair. #### What's Changed #### 👍 Improvements - **Custom screen transitions** - In 3.30.0, we've introduced a support for custom transition animations while making a "go back" gesture. Made by [@​piaskowyk](https://togithub.com/piaskowyk) and [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1913](https://togithub.com/software-mansion/react-native-screens/pull/1913) - **Support for VisionOS is here!** - From now, react-native-screens offers bundled support for VisionOS platform. Made by [@​okwasniewski](https://togithub.com/okwasniewski) in [https://github.com/software-mansion/react-native-screens/pull/2025](https://togithub.com/software-mansion/react-native-screens/pull/2025) - **`slide_from_left` transition on iOS** - You can use `slide_from_left` animation that will be used for pushing or popping a new screen. Made by [@​kirillzyusko](https://togithub.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/2057](https://togithub.com/software-mansion/react-native-screens/pull/2057) - Add `cancelSearch` command on SearchBar by [@​Jasonzj](https://togithub.com/Jasonzj) in [https://github.com/software-mansion/react-native-screens/pull/1987](https://togithub.com/software-mansion/react-native-screens/pull/1987) - Fixed Android screen stack animation by [@​janicduplessis](https://togithub.com/janicduplessis) in [https://github.com/software-mansion/react-native-screens/pull/2019](https://togithub.com/software-mansion/react-native-screens/pull/2019) #### 🐛 Bug fixes - Not working hitslop for headerRight/Left views by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1995](https://togithub.com/software-mansion/react-native-screens/pull/1995) - App freeze when navigating back from any modal nested in contained modal by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1996](https://togithub.com/software-mansion/react-native-screens/pull/1996) - Incorrect safe area on transparent modals using landscape orientation by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2008](https://togithub.com/software-mansion/react-native-screens/pull/2008) - Invalid orientation of contained modals by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2011](https://togithub.com/software-mansion/react-native-screens/pull/2011) - Modify the decorFitsSystemWindow parameter in setNavigationBarHidden by [@​jiyong1](https://togithub.com/jiyong1) in [https://github.com/software-mansion/react-native-screens/pull/1988](https://togithub.com/software-mansion/react-native-screens/pull/1988) - Avoid race condition related to state on the new arch by [@​j-piasecki](https://togithub.com/j-piasecki) in [https://github.com/software-mansion/react-native-screens/pull/2024](https://togithub.com/software-mansion/react-native-screens/pull/2024) - Check for multiple screens while changing screen orientation by [@​uzegonemad](https://togithub.com/uzegonemad) in [https://github.com/software-mansion/react-native-screens/pull/2035](https://togithub.com/software-mansion/react-native-screens/pull/2035) - Fix setting incorrect measure with native header by [@​WoLewicki](https://togithub.com/WoLewicki) and [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2028](https://togithub.com/software-mansion/react-native-screens/pull/2028) - Add notifying for header height change, fix header height values by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2075](https://togithub.com/software-mansion/react-native-screens/pull/2075) - Change context while running `runOnUiQueueThread` on 0.73 with Bridgeless by [@​cortinico](https://togithub.com/cortinico) in [https://github.com/software-mansion/react-native-screens/pull/2022](https://togithub.com/software-mansion/react-native-screens/pull/2022) - Use reactApplicationContext in onScreenChanged by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/2046](https://togithub.com/software-mansion/react-native-screens/pull/2046) - Remove calculating status bar height in useAnimatedHeaderHeight when header is not shown by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2033](https://togithub.com/software-mansion/react-native-screens/pull/2033) - Handle setting `display` for `_viewConfig` attribute by [@​WoLewicki](https://togithub.com/WoLewicki) and [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2071](https://togithub.com/software-mansion/react-native-screens/pull/2071) - Fix crash with searchResultsController in RNSSearchBar by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2004](https://togithub.com/software-mansion/react-native-screens/pull/2004) - Add constraints for velocity in `goBackGesture` screen transition by [@​piaskowyk](https://togithub.com/piaskowyk) in [https://github.com/software-mansion/react-native-screens/pull/2061](https://togithub.com/software-mansion/react-native-screens/pull/2061) - Add view check for getting StackView in `goBackGesture` by [@​piaskowyk](https://togithub.com/piaskowyk) in [https://github.com/software-mansion/react-native-screens/pull/2060](https://togithub.com/software-mansion/react-native-screens/pull/2060) - Change default value of context of ScreenGestureDetector, add warning for goBackGesture by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2013](https://togithub.com/software-mansion/react-native-screens/pull/2013) - Move GHContext from gesture-handler to native-stack by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2017](https://togithub.com/software-mansion/react-native-screens/pull/2017) - Change default gesture from Tap to Fling, fix failing CI by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2023](https://togithub.com/software-mansion/react-native-screens/pull/2023) #### 🔢 Miscellaneous - **Drop React Native 0.64 - 0.67 since 3.30.0** by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2036](https://togithub.com/software-mansion/react-native-screens/pull/2036) - Remove mixed CJS/ESM, refactorize index.native.tsx by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1982](https://togithub.com/software-mansion/react-native-screens/pull/1982) - Add react-navigation as submodule & use it in test applications by [@​kkafar](https://togithub.com/kkafar) and [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1993](https://togithub.com/software-mansion/react-native-screens/pull/1993) - Unify member-field naming convention in Kotlin by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1999](https://togithub.com/software-mansion/react-native-screens/pull/1999) - Update compatibility table with supported RN versions with Fabric by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/2001](https://togithub.com/software-mansion/react-native-screens/pull/2001) - Change name of `headerBackButtonClicked` event by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/2015](https://togithub.com/software-mansion/react-native-screens/pull/2015) - Stabilize Android E2E tests by [@​kirillzyusko](https://togithub.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/2062](https://togithub.com/software-mansion/react-native-screens/pull/2062) - Update Podfiles in Example projects, update RN in FabricExample to 0.73 by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1989](https://togithub.com/software-mansion/react-native-screens/pull/1989) - Update React Native to 0.73.4, change Cocoapods version by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2032](https://togithub.com/software-mansion/react-native-screens/pull/2032) - Configure yarn version in package.json by [@​bakkerjoeri](https://togithub.com/bakkerjoeri) in [https://github.com/software-mansion/react-native-screens/pull/2077](https://togithub.com/software-mansion/react-native-screens/pull/2077) - Bump ip from 1.1.8 to 1.1.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/2038](https://togithub.com/software-mansion/react-native-screens/pull/2038) - Bump ip from 1.1.8 to 1.1.9 in example apps by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/2044](https://togithub.com/software-mansion/react-native-screens/pull/2044) #### New Contributors - [@​jiyong1](https://togithub.com/jiyong1) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1988](https://togithub.com/software-mansion/react-native-screens/pull/1988) - [@​Jasonzj](https://togithub.com/Jasonzj) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1987](https://togithub.com/software-mansion/react-native-screens/pull/1987) - [@​j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/2024](https://togithub.com/software-mansion/react-native-screens/pull/2024) - [@​cortinico](https://togithub.com/cortinico) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/2022](https://togithub.com/software-mansion/react-native-screens/pull/2022) - [@​okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/2025](https://togithub.com/software-mansion/react-native-screens/pull/2025) - [@​uzegonemad](https://togithub.com/uzegonemad) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/2035](https://togithub.com/software-mansion/react-native-screens/pull/2035) - [@​bakkerjoeri](https://togithub.com/bakkerjoeri) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/2077](https://togithub.com/software-mansion/react-native-screens/pull/2077) #### 🙌 Thank you for your contributions! **Full Changelog**: software-mansion/react-native-screens@3.29.0...3.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
This was referenced May 22, 2024
This was referenced May 25, 2024
This was referenced Jun 3, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…re-mansion#2023) ## Description Unfortunately, the `Tap` gesture as the default gesture in ScreenGestureDetector breaks the back button on Android and iOS. Somehow, gesture detector while "tapping" just taps and holds the back button, resulting in breaking CI and our testing apps. This PR changes this gesture to `Fling`, resulting in correct behavior. It cannot be changed to `Manual` gesture, since it also breaks the iOS CI. ## Changes - Changed gesture from Tap to Fling - Updated detox from 20.11.4 to 20.17.0 - Fixed Android E2E tests by building the bundle with .so files on x86_64 architecture - Changed scroll action that was opening background apps preview on Android 33 (and higher) levels - Adjusted CI parameters, fixed the typo of artifact names ## Test code and steps to reproduce You can go through Example app and try to click back button in `Events`. Right now it should work properly. ## Checklist - [x] Ensured that CI passes --------- Co-authored-by: m-bert <michal.bert@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://renovatebot.com){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately, the
Tapgesture as the default gesture in ScreenGestureDetector breaks the back button on Android and iOS. Somehow, gesture detector while "tapping" just taps and holds the back button, resulting in breaking CI and our testing apps.This PR changes this gesture to
Fling, resulting in correct behavior. It cannot be changed toManualgesture, since it also breaks the iOS CI.Changes
Test code and steps to reproduce
You can go through Example app and try to click back button in
Events. Right now it should work properly.Checklist