fix(Android): screen goes blank when going back on fabric#2465
Merged
Conversation
kkafar
reviewed
Oct 29, 2024
kkafar
left a comment
kkafar
left a comment
Member
There was a problem hiding this comment.
Good catch, however I would like to avoid exporting the NativeScreensModule. @maciekstosio works on it in separate PR
kkafar
requested changes
Oct 30, 2024
kkafar
left a comment
kkafar
left a comment
Member
There was a problem hiding this comment.
It just came to my mind that we could do following 👇🏻 just temporarily, before we complete screen transition API migration by @maciekstosio.
I would be even fine to leave it this way. Its ugly - true, but it achieves all I want:
- We ensure the turbomodule is loaded
- We'll be able to remove it from public interface at any point w/o breaking change.
Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to fix current screen going blank on Android when returning to the previous one. The issue has been already fixed by #2134, but re-appeared recently. After a quick bisect it turned out that #2412 caused the regression. Bringing back the removed
NativeScreensModuleexport fixes the issue.Fixes #1685
Changes
Test2282.tsxreproScreenshots / GIFs
Before
Screen.Recording.2024-10-29.at.15.20.41.mov
After
Screen.Recording.2024-10-29.at.15.21.31.mov
Test code and steps to reproduce
Test2282.tsxreproChecklist