feat(nft-meta-data-pointer): migrate frontend to @solana/kit - #673
Open
Harsh-H-Shah wants to merge 4 commits into
Open
feat(nft-meta-data-pointer): migrate frontend to @solana/kit#673Harsh-H-Shah wants to merge 4 commits into
Harsh-H-Shah wants to merge 4 commits into
Conversation
Follow-up to solana-foundation#657, where dev-jodee asked for web3.js to be dropped in favor of kit. Replaces @anchor-lang/core with a Codama-generated @solana/kit client (from a real anchor-build-extracted IDL, not the hand-maintained one), and @solana/wallet-adapter-react with @solana/connector for wallet connection. @magicblock-labs/gum-react-sdk (the session-key feature) is pinned to @solana/web3.js and @solana/wallet-adapter-react in its own published API and predates kit, so full removal isn't possible while keeping that feature. That stays as a single, documented legacy boundary (utils/legacyBridge.ts, contexts/SessionProvider.tsx) bridging the one connected wallet into the shape gum-sdk needs, rather than running two separately-connected wallet instances. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Greptile SummaryThe follow-up updates the Kit-based game-state timer so locally refilled energy is published through provider state and the countdown is cleared at maximum energy.
Confidence Score: 5/5The reviewed follow-up appears safe to merge because no blocking failure remains from the previous game-state findings. The current timer publishes refilled energy through a new player-state object and clears the countdown when energy is at maximum, so neither previously reported stale-state path remains. Important Files Changed
Reviews (4): Last reviewed commit: "fix(nft-meta-data-pointer): consolidate ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Greptile caught this on review: the refill-tick loop computed incremented energy/lastLogin into local variables but never wrote them back to playerState, so the displayed energy counter stayed stale between real account-change notifications. The previous BN-based version got away with mutating playerState.energy in place and relying on the same effects setTimePassed/setEnergyNextIn calls to force a re-render - that trick got dropped when the local let variables were introduced. Now commits the computed values via setPlayerState explicitly, only when something changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Greptile flagged this on review. Pre-existing behavior (the same early return existed before this migration) surfaced by having Greptile look closely at code already being touched here: once playerState.energy hits MAX_ENERGY, the interval returned early without ever calling setEnergyNextIn(0), so the last computed countdown stayed on screen next to a full energy bar indefinitely. Splits the guard so the max-energy case explicitly clears the countdown before returning. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ient with kit Point declare_id! and Anchor.toml at the program actually deployed on devnet, so a fresh anchor build reproduces the checked-in IDL. Route the wallet connector and the session-key Connection through the same RPC_URL the kit client uses, so NEXT_PUBLIC_RPC moves every cluster connection together instead of leaving two endpoints hardcoded. Reset playerDataPDA and check the abort signal when the signer changes, so a click during the async PDA derivation cannot pair a new signer with the previous wallet's player account. Replace the axios-based WrappedConnection with a DAS client built on kit's createJsonRpcApi, following the pattern in solana-foundation/templates kit/nextjs-das-nfts. The DAS endpoint carries a provider credential, so it now comes from NEXT_PUBLIC_DAS_RPC with no default and the NFT list reports when it is unset. Move the remaining web3.js conversions behind legacyBridge and add a typecheck script, which needs generate-client to have run.
Collaborator
|
Thanks @Harsh-H-Shah -- i pushed a small commit on top of yours. Just for future reference, I wanted you to make sure you see |
amilz
approved these changes
Aug 6, 2026
dev-jodee
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #657, where dev-jodee asked for web3.js to be dropped in favor of kit. Replaces @anchor-lang/core with a Codama-generated @solana/kit client (from a real anchor-build-extracted IDL, not the hand-maintained one), and @solana/wallet-adapter-react with @solana/connector for wallet connection.
@magicblock-labs/gum-react-sdk (the session-key feature) is pinned to @solana/web3.js and @solana/wallet-adapter-react in its own published API and predates kit, so full removal isn't possible while keeping that feature. That stays as a single, documented legacy boundary (utils/legacyBridge.ts, contexts/SessionProvider.tsx) bridging the one connected wallet into the shape gum-sdk needs, rather than running two separately-connected wallet instances.