Widen ulp tolerance#397
Merged
Merged
Conversation
55ae2d3 to
a3e5f3b
Compare
joncinque
reviewed
May 26, 2026
Contributor
joncinque
left a comment
There was a problem hiding this comment.
Makes sense! Can you add a worst-case test where it's possible to get close to the maximum ULP? Or something that fails on 9?
Member
Author
Was not able to generate an example larger than 5 (proves the current allowance is too small). Added that test.
Anything 10 and lower will now pass. The audit provided a proof it is not possible higher. |
joncinque
approved these changes
May 27, 2026
Contributor
joncinque
left a comment
There was a problem hiding this comment.
Ah ok, I thought they had an example for 9. This works though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During audit was provided a case where the ULP diff was > 4. Recommended widening to 10:
Practically speaking, this means the integer and float implementations (not including highly unlikely overflow cases) do not differ more than 1280 lamports.
No impact to product code, just tests.