Skip to content

Fix: stop writing foaf:knows when sharing a resource - #65

Merged
PreciousOritsedere merged 2 commits into
mainfrom
56-dont-assert-foaf-knows-on-share
Aug 3, 2026
Merged

Fix: stop writing foaf:knows when sharing a resource#65
PreciousOritsedere merged 2 commits into
mainfrom
56-dont-assert-foaf-knows-on-share

Conversation

@PreciousOritsedere

@PreciousOritsedere PreciousOritsedere commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

fixes #56 and closes #47

Comment thread app/lib/helpers/contactUtils.ts Outdated
throw error;
}
}
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure there is an EOF character here - and open an issue to set up eslint so that we have linting rules stopping this from happening in the future.

@jeswr jeswr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still keep track of who we have shared resources with so that they turn up as "quick search" options.

This data should be maintained as a set of contacts in a private resource linked to from the preference file of the user sharing the resource.

@PreciousOritsedere

Copy link
Copy Markdown
Contributor Author

We should still keep track of who we have shared resources with so that they turn up as "quick search" options.

This data should be maintained as a set of contacts in a private resource linked to from the preference file of the user sharing the resource.

This PR only removes that write on share (fixes #56 / #47). I have opened a follow-up issue to store shared contacts in a private resource linked from the preferences file for quick search(we can discuss the approach for this)

@jeswr jeswr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PreciousOritsedere
PreciousOritsedere merged commit 74a658e into main Aug 3, 2026
@PreciousOritsedere
PreciousOritsedere deleted the 56-dont-assert-foaf-knows-on-share branch August 3, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't assume user knows agent being 'shared' with Don't assume WebID is Solid resource

2 participants