Skip to content

Avoid FlutterVlcPlayerFactory new instances onAttachedToActivity #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solid-software merged 2 commits into from
Mar 29, 2021
Merged

Avoid FlutterVlcPlayerFactory new instances onAttachedToActivity #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa8c2af
Avoid FlutterVlcPlayerFactory new instances onAttachedToActivity
GuillermoDLCO Mar 25, 2021
4b431c1
Avoid FlutterVlcPlayerFactory instances in registerWith
GuillermoDLCO Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 33 additions & 29 deletions ..._player/android/src/main/java/software/solid/fluttervlcplayer/FlutterVlcPlayerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,21 @@ public FlutterVlcPlayerPlugin() {

@SuppressWarnings("deprecation")
public static void registerWith(io.flutter.plugin.common.PluginRegistry.Registrar registrar) {
flutterVlcPlayerFactory =
new FlutterVlcPlayerFactory(
registrar.messenger(),
registrar.textures(),
registrar::lookupKeyForAsset,
registrar::lookupKeyForAsset
);
registrar
.platformViewRegistry()
.registerViewFactory(
VIEW_TYPE,
flutterVlcPlayerFactory
);
if (flutterVlcPlayerFactory == null) {
flutterVlcPlayerFactory =
new FlutterVlcPlayerFactory(
registrar.messenger(),
registrar.textures(),
registrar::lookupKeyForAsset,
registrar::lookupKeyForAsset
);
registrar
.platformViewRegistry()
.registerViewFactory(
VIEW_TYPE,
flutterVlcPlayerFactory
);
}
registrar.addViewDestroyListener(view -> {
stopListening();
return false;
Expand All @@ -56,22 +58,24 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {
@RequiresApi(api = Build.VERSION_CODES.N)
@Override
public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) {
final FlutterInjector injector = FlutterInjector.instance();
//
flutterVlcPlayerFactory =
new FlutterVlcPlayerFactory(
flutterPluginBinding.getBinaryMessenger(),
flutterPluginBinding.getTextureRegistry(),
injector.flutterLoader()::getLookupKeyForAsset,
injector.flutterLoader()::getLookupKeyForAsset
);
flutterPluginBinding
.getPlatformViewRegistry()
.registerViewFactory(
VIEW_TYPE,
flutterVlcPlayerFactory
);
//
if (flutterVlcPlayerFactory == null) {
final FlutterInjector injector = FlutterInjector.instance();
//
flutterVlcPlayerFactory =
new FlutterVlcPlayerFactory(
flutterPluginBinding.getBinaryMessenger(),
flutterPluginBinding.getTextureRegistry(),
injector.flutterLoader()::getLookupKeyForAsset,
injector.flutterLoader()::getLookupKeyForAsset
);
flutterPluginBinding
.getPlatformViewRegistry()
.registerViewFactory(
VIEW_TYPE,
flutterVlcPlayerFactory
);
//
}
startListening();
}

Expand Down