add vlc options from flutter#64
Conversation
|
Nice 👍 thanks for your contribution @pharshdev! Is there a way you can remove "System.out.println" - so we can have more clean console for users + update changeling.md to include this new version changes? @mitchross if you have time - could you please take a look and let us know what you think about it? |
|
I will review. |
|
ping @solid-software |
mitchross
left a comment
mitchross
left a comment
There was a problem hiding this comment.
ping @solid-software
When will you merge it?
When comments are resolved.
| } | ||
|
|
||
| Future<void> _initialize(String url) async { | ||
| Future<void> _initialize( |
There was a problem hiding this comment.
you should either make a new function called initializeWithOptions or use optional parameters. https://stackoverflow.com/questions/49734608/function-overloading-in-dart
There was a problem hiding this comment.
API versioning states that no breaking changing. This is technically a breaking change. So lets fix that by providing optional params or a new initialization method. The latter is preferred.
| // with LibVLC on the platform side. | ||
| if (_controller.hasClients) { | ||
| await _controller._initialize(widget.url); | ||
| await _controller._initialize(widget.hwAcc, widget.options, widget.url); |
|
ping @pharshdev. Please resolve the mentioned conflicts. |
|
If @pharshdev doesnt take care of this, ill fork and take care of it this week. |
|
Fix for this PR #84 |
4 participants
i think it would be nice to have this.