Implement some useful API methods by NBTX · Pull Request #7 · solid-software/flutter_vlc_player

NBTX · 2019-05-05T02:56:28Z

This PR adds the following methods:

setPlaybackSpeed(double speed)
setStreamURL(String url) (previous implementation moved to initialize())
addListener(VoidCallback listener)
removeListener(VoidCallback listener)
clearListeners()
setTime(int time)
play()
pause()
stop()

and exposes the following properties:

aspectRatio
size
- width
- height
position
duration
playbackSpeed
playingState [PlaybackState - one of STOPPED, BUFFERING, PLAYING]

solid-software · 2019-05-05T16:14:03Z

Wow @NBTX - thanks for your contribution! Give us some time to review everything so we can merge and then publish new version to the pub.

NBTX · 2019-05-05T18:08:10Z

@solid-software sorry, I've been testing this as I go so it's gotten kind of messy in here. If there's anything you want me to do to clean this up, let me know.
I pushed all this crap before I realised anyone noticed the PR 😄

solid-software · 2019-05-05T18:37:48Z

Hey, no worries - just let us know when you are done so we can schedule review & merge.

NBTX · 2019-05-05T21:18:10Z

@solid-software Sure thing. I'd also like to have a look at the iOS side. If it's not too mind-boggling (I haven't really touched iOS development) I might give it a go with implementing it on that side.

(Also I guess it would be nice to have everything properly documented 😄- I hastily typed my first message up because it was something like 3AM when I committed it.)

wolfljj · 2019-05-08T15:40:53Z

@NBTX how can i use your fork version?

NBTX · 2019-05-10T18:58:19Z

@wolfljj I don't know that you'll have success with it (I still need to do a bit more work on this - at least, I'm having some trouble implementing it into my app), however if you want to give it a shot, add this to the dependencies section of your pubspec.yaml:

  flutter_vlc_player:
    git:
      url: git://github.com/NBTX/flutter_vlc_player.git
      ref: master

Here's an example implementation:
https://github.com/NBTX/flutter_vlc_player/blob/master/example/lib/main.dart

NBTX · 2019-07-02T01:00:52Z

Hey just to update everyone watching this PR. This is not dead, we're prepping it for use it over at @ApolloTVofficial (@ApolloTVofficial/kamino) for our built-in player.

This has kind of been on-hold because I've experienced some bugs implementing it into our app and I wanted to sort of clean everything up both in here and in our app before I throw a ton more features at it and work on landing this PR. Plus, I'm reading up on Objective-C and Swift to work on the iOS side of this project.

TL;DR, expect some more commits soon cleaning up the code, along with the necessary iOS platform channel code to even out this PR and get it ready to land.

solid-software · 2019-07-02T08:25:23Z

Thanks for the update @NBTX! Great job!

verylovestars · 2019-07-25T15:36:25Z

@NBTX Hi, you did not abandon the development?

moeiscool · 2020-02-20T20:39:14Z

@moeiscool Did you implement your VlcPlayerController as follows?
final VlcPlayerController controller = new VlcPlayerController(
      // Start playing as soon as the video is loaded.
      onInit: (){
          controller.play();
      }  
);
Edit: Also I'm positive the other changes are to do with permissions rather than line endings - though I'm familiar with what you're describing.

yes i did, first test i missed it and it just crashed. after that i noticed it in the compare on the PR. it doesn't crash after adding that but it does the placeholder thing forever

iPhone XS Max, iOS 13.1.3

NBTX · 2020-02-20T21:28:58Z

@moeiscool Can you open a new issue (just so we're not chasing two things on the same thread) - and I'll follow up while we merge this one.

NBTX · 2020-02-20T21:29:55Z

@solid-software I'll take a look, I noticed upon looking again that aside from the permissions tweaks there is a lot of extra garbage for some reason, so I'll try and cut that down (per your comments).

NBTX · 2020-02-20T22:28:27Z

@solid-software that should be the junk removed. Again, I've left the permissions changes as those are correct but I can remove them if you want.

mitchross · 2020-02-22T17:32:07Z

This PR doesnt build for me when referenced in another project. lib/ui/widgets/CameraVLCStreamCard.dart:42:26: Error: The method 'VlcPlayer' isn't defined for the class 'CameraStreamVLCCardState'.

'CameraStreamVLCCardState' is from 'package:muticam_dashboard/ui/widgets/CameraVLCStreamCard.dart' ('lib/ui/widgets/CameraVLCStreamCard.dart').
Try correcting the name to the name of an existing method, or defining a method named 'VlcPlayer'.
child: VlcPlayer(

NBTX · 2020-02-22T19:25:39Z

@mitchross check the imports. This changes the API and consolidates the main functionality into a single file.

mitchross · 2020-02-25T05:33:41Z

I got past import issues, now im seeing this error being logged when the app runs.

[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: NoSuchMethodError: The method 'call' was called on null.
Receiver: null
Tried calling: call()
#0 Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1 VlcPlayerController._initialize (package:flutter_vlc_player/flutter_vlc_player.dart:279:5)
#2 _rootRunUnary (dart:async/zone.dart:1134:38)
#3 _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#4 _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
#5 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#6 Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#7 Future._completeWithValue (dart:async/future_impl.dart:526:5)
#8 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:34:15)
#9 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:293:13)
#10 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart)
#11 _rootRunUnary (dart:asy<…>

solid-software

I reviewed most of the code, looks good to me just wanted to clear last piece I indicated in comments and I hope we can move it forward.

Thanks again for your contribution @NBTX !

solid-software · 2020-02-26T14:27:04Z

+  }
+}
+
+class VlcPlayerController {


@NBTX is there any particular reason to place all classes in one file? I think it violates SRP - if we want to simplify imports we can create library, but that will make migration a bit more complex. What do you think?

If you merge this PR, @solid-software you will need to version the library to 2.0.0 as the code is breaking change and backwards compatibility is broken. I tested this by importing this library in my own code and I had to refactor the VLC widget.

@mitchross I changed the version code.
I think I will follow @solid-software's advice and use multiple files. When I refactored initially one file made sense, but obviously it no longer does.

Cool. let me know when you are ready for a retest!

i wanna test things and give thumbs up to things

@NBTX When are you going to update?

Michael24884 · 2020-03-04T17:26:37Z

Hello! Are there any plans on adding http headers? Some videos that I use require a referer

mitchross · 2020-03-13T01:30:48Z

If anyone wants this PR, I completed it on my fork,fixed the build errors, and upgraded to latest vlckit. I don't want to take the original authors credit, so I'm not gonna submit a PR. However, we haven't seen any communication form @NBTX , so if you want to go grab this PR without waiting you can use my version. https://github.com/mitchross/flutter_vlc_player

Michael24884 · 2020-03-13T03:36:50Z

@mitchross hey thanks a lot for cleaning this up. By any chance do you know if it’s possible to implement headers? Really crucial for my project

moeiscool · 2020-03-13T03:58:48Z

im not really qualified to speak about this but i’ll lay in my suggestion. look through mitch’s code to see how the library is used and executes the connection. then find a sample of code somewhere in the net that adds the headers to this library or kind of library. i’m interested in learning this stuff, i’ll be your ios/android testing guinea pig and try to help with C stuff :). Since mitch did a whole bunch of the heavy lifting already we can try and figure something together, eh?

On Thu, Mar 12, 2020 at 8:37 PM Michael24884 ***@***.***> wrote: @mitchross <https://github.com/mitchross> hey thanks a lot for cleaning this up. By any chance do you know if it’s possible to implement headers? Really crucial for my project — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6USQEWK3S5WRZXTQCZUTDRHGS55ANCNFSM4HK2G4GQ> .

-- Thanks! Moe Alam Shinobi Systems CEO & Founder shinobi.video

mitchross · 2020-03-13T04:44:31Z

@mitchross hey thanks a lot for cleaning this up. By any chance do you know if it’s possible to implement headers? Really crucial for my project

EDIT- Not possible. https://forum.videolan.org/viewtopic.php?t=129773

I would do the suggestion of forwarding the request on another server. Such that request to video from VLC APP -> middle ware server -> middleware server adds referrer ( easily set up with express/nodejs ) -> source video stream

mitchross · 2020-03-13T23:22:15Z

@Michael24884 See my comment above, github wont let me tag you in the edit.

Michael24884 · 2020-03-17T15:35:22Z

It looks like referrers are allowed based on the forum response? Is it possible to set it? That’s the only header I need to pass

mitchross · 2020-03-17T16:29:07Z

@Michael24884 I see how to do it now. Can you give me an example url that requires a http-referrer so I can test ?

Michael24884 · 2020-03-17T16:41:47Z

@mitchross sure!

url: https://hls11xx.cdnfile.info/videos/hls/NPLp7OCq9BNxZSsXhO0aDQ/1584477608/124087/943a055676e7363e249acbbda60e5ecb/dub.11.m3u8

referrer: http://vidstreaming.io

solid-software · 2020-04-03T17:39:40Z

Another PR landed that continued work from this PR so I'm closing this now.

SamJakob added 2 commits May 4, 2019 19:04

Attempt to migrate to surfaceview (sdk16+ support)

d1bb36f

Add progress, add playback state, add playback speed

87593fd

NBTX mentioned this pull request May 5, 2019

When I run it says #4

Closed

NBTX and others added 4 commits May 5, 2019 12:36

Add removeListener method

7edd942

Increment version to reflect changes

db53b2a

Add aspect ratio support

29c18a6

Merge branch 'master' of github.com:NBTX/flutter_vlc_player

2d1a0a4

NBTX force-pushed the master branch from c664808 to 2d1a0a4 Compare May 5, 2019 12:24

Add playing and buffering states

53a0e4d

NBTX force-pushed the master branch from ef70281 to 53a0e4d Compare May 5, 2019 12:54

Refactor controller into vlc_player.dart

289ce58

Correctly communicate meta information

e5eebee

NBTX force-pushed the master branch from 004f2db to e5eebee Compare May 5, 2019 16:56

SamJakob added 3 commits May 5, 2019 18:06

Don't stop when player is null

35e37de

Disable autoplay

3a7c44e

Bug fixes.

9a8e02c

NBTX force-pushed the master branch from 5f968fe to 9a8e02c Compare May 5, 2019 17:55

SamJakob added 3 commits May 5, 2019 19:03

Refactor seek method

3f4c725

Refactor seek method

f4c1295

Fix seek method

ac4db1c

Used wrong data type - use num instead

45d834f

NBTX added 4 commits February 20, 2020 22:10

Update .gitignore

af76c0d

Clean up files

01f5b73

Add trailing newline

0f63027

Remove temporary files

32dec37

moeiscool mentioned this pull request Feb 21, 2020

live stream crashes but recorded file plays (PR #7 Test) #27

Open

solid-software suggested changes Feb 26, 2020

View reviewed changes

mitchross mentioned this pull request Mar 27, 2020

Implement some useful API methods #7 (V2) #35

Merged

solid-software closed this Apr 3, 2020

Marcus-Ospicon mentioned this pull request Apr 12, 2020

The example does not work on Android #39

Closed

shichunlei mentioned this pull request Oct 14, 2020

Message from debugger: Terminated due to memory issue #121

Open

Arialena mentioned this pull request Nov 30, 2021

Exception: stopRendererScanning() was called on an uninitialized VlcPlayerController. #281

Open

azulmouad mentioned this pull request Oct 22, 2023

Android and TV App Crashing Error #448

Open

hezhipengzipp mentioned this pull request Aug 28, 2025

Disconnect from the network FlutterVlcPlayer.stop will cause the interface ANR, which is very likely to occur #538

Open

Uh oh!

Conversation

NBTX commented May 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solid-software commented May 5, 2019

Uh oh!

NBTX commented May 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solid-software commented May 5, 2019

Uh oh!

NBTX commented May 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfljj commented May 8, 2019

Uh oh!

NBTX commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NBTX commented Jul 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solid-software commented Jul 2, 2019

Uh oh!

verylovestars commented Jul 25, 2019

Uh oh!

moeiscool commented Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NBTX commented Feb 20, 2020

Uh oh!

NBTX commented Feb 20, 2020

Uh oh!

NBTX commented Feb 20, 2020

Uh oh!

mitchross commented Feb 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NBTX commented Feb 22, 2020

Uh oh!

mitchross commented Feb 25, 2020

Uh oh!

solid-software left a comment

Choose a reason for hiding this comment

Uh oh!

solid-software Feb 26, 2020

Choose a reason for hiding this comment

Uh oh!

mitchross Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

NBTX Feb 27, 2020

Choose a reason for hiding this comment

Uh oh!

mitchross Feb 28, 2020

Choose a reason for hiding this comment

Uh oh!

moeiscool Feb 29, 2020

Choose a reason for hiding this comment

Uh oh!

mitchross Mar 11, 2020

Choose a reason for hiding this comment

Uh oh!

Michael24884 commented Mar 4, 2020

Uh oh!

mitchross commented Mar 13, 2020

Uh oh!

Michael24884 commented Mar 13, 2020

Uh oh!

moeiscool commented Mar 13, 2020 via email

Uh oh!

mitchross commented Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mitchross commented Mar 13, 2020

Uh oh!

Michael24884 commented Mar 17, 2020

Uh oh!

mitchross commented Mar 17, 2020

NBTX commented May 5, 2019 •

edited

Loading

NBTX commented May 5, 2019 •

edited

Loading

NBTX commented May 5, 2019 •

edited

Loading

NBTX commented May 10, 2019 •

edited

Loading

NBTX commented Jul 2, 2019 •

edited

Loading

moeiscool commented Feb 20, 2020 •

edited

Loading

mitchross commented Feb 22, 2020 •

edited

Loading

mitchross commented Mar 13, 2020 •

edited

Loading