Fix iOS takeSnapshot not working#83
Conversation
Fix iOS takeSnapshot not working
solid-software
left a comment
solid-software
left a comment
There was a problem hiding this comment.
Hi @Antonimo, thanks for your PR!
I've added couple suggestions - could you please take a look and let us know what you think?
| } else { | ||
| print("no arguments") |
There was a problem hiding this comment.
We usually try to avoid print statements.
There was a problem hiding this comment.
Debug Log statement may be better
|
|
||
| Future<Uint8List> takeSnapshot() async { | ||
| var result = await _methodChannel.invokeMethod("getSnapshot"); | ||
| var result = await _methodChannel.invokeMethod("getSnapshot", {'test': ''}); |
There was a problem hiding this comment.
Do we need to pass this 'test' data always or it can be removed?
There was a problem hiding this comment.
it was a quick fix, if no arguments then the invoke is ignored
There was a problem hiding this comment.
just change 'test' to 'getSnapShot' then
|
@solid-software @mitchross updated |
|
@Antonimo did you push up your changes? I dont see it. NVM see it now. All good. @solid-software LGTM! |
|
Thanks @Antonimo @mitchross! |
4 participants
Fix iOS takeSnapshot not working