Skip to content

Added error handling#89

Merged
solid-software merged 3 commits into
solid-software:masterfrom
alr2413:master
Aug 6, 2020
Merged

Added error handling#89
solid-software merged 3 commits into
solid-software:masterfrom
alr2413:master

Conversation

@alr2413

@alr2413 alr2413 commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

I have added event to report vlc error to the flutter side.

@mitchross

Copy link
Copy Markdown
Contributor

Looks fine to me

@illia-romanenko illia-romanenko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you @alr2413 !

Can you please update changelog and pubspec version so we can quickly release it?

@alr2413

alr2413 commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

I have done that.
Thanks.

@alr2413

alr2413 commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

ping @illia-romanenko.

@solid-software solid-software left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants