Add Function to Change/ADD subtitle and change the audio track by rikaweb · Pull Request #91 · solid-software/flutter_vlc_player

rikaweb · 2020-08-05T18:36:25Z

Add Function to Change/ADD subtitle and change the audio track

alr2413 · 2020-08-06T06:48:50Z

Hi,

Is it possible to return the name or text of audios & subtitles list in addition to the index?

Thanks.

solid-software · 2020-08-06T06:59:32Z

Great job, thanks for the PR @rikaweb!

Do you plan on adding iOS part for it?

rikaweb · 2020-08-06T18:57:04Z

Hi
@solid-software I just update it for android and test it on android, I am java developer and have no preference on ios. maybe we can publish it and ask the IOS developer to help.

solid-software · 2020-08-06T19:06:14Z

As we declare support for both mobile platforms (Android and iOS) I think it would be hard to merge without adding iOS part to it. Let's see if somebody can help here to add iOS part of it so we can merge.

rikaweb · 2020-08-06T19:15:35Z

Hi,

Is it possible to return the name or text of the audios & subtitles list in addition to the index?

Thanks.

HI @alr2413
The VLC use this function for audio and subtitle description :
/**
* Get the list of available SPU (subtitle and audio tracks).
*/
public TrackDescription[] getSpuTracks() {
return nativeGetSpuTracks();
}
So this method in 'FlutterVideoView.java' file can provide what you are searching for
https://stackoverflow.com/questions/48976386/libvlc-how-do-i-know-if-subtitles-text-track-are-external-or-part-of-video-co

Thanks

mitchross · 2020-08-10T13:48:36Z

@solid-software I can do iOS part this week.... Is it possible to change this PR to a new feature branch on solid software repo? Forking a fork is really painful. If we make a new branch on solid software called, "feature/audio-track" , merge this PR into that branch, then I will fork the solid software repo, add in iOS. Finally we can PR the feature/audio branch to master.

solid-software · 2020-08-11T09:42:02Z

What if @rikaweb adds you to rikaweb:master so you can make the changes here? I think that might simplify it a bit.

alr2413 · 2020-08-11T14:51:29Z

I think, it's better to have a dev-branch beside master branch for developing purpose.

rikaweb · 2020-08-11T15:02:32Z

What if @rikaweb adds you to rikaweb:master so you can make the changes here? I think that might simplify it a bit.

I can do that if needed!

mitchross · 2020-08-11T15:59:49Z

What if @rikaweb adds you to rikaweb:master so you can make the changes here? I think that might simplify it a bit.

I can do that if needed!

Add me to your master, I'll make iOS changes

rikaweb · 2020-08-11T16:01:42Z

What if @rikaweb adds you to rikaweb:master so you can make the changes here? I think that might simplify it a bit.

I can do that if needed!

Add me to your master, I'll make iOS changes

Added!

mitchross · 2020-08-14T00:50:26Z

@rikaweb I need a video file to test this with thats hosted online. How did you test your android changes?

rikaweb · 2020-08-20T15:34:26Z

@rikaweb I need a video file to test this with thats hosted online. How did you test your android changes?

I add subtitles to video first and then test the change subtitle option.

mitchross · 2020-08-20T17:37:50Z

@rikaweb I need a video file to test this with thats hosted online. How did you test your android changes?

I add subtitles to video first and then test the change subtitle option.

Can you please provide specific instructions step by step? Local video? hosted video ? what code are you using to add subtitles? If you can provide me with this, I can do the ios code.

rikaweb · 2020-08-20T17:52:34Z

@rikaweb I need a video file to test this with thats hosted online. How did you test your android changes?

I add subtitles to video first and then test the change subtitle option.

Can you please provide specific instructions step by step? Local video? hosted video ? what code are you using to add subtitles? If you can provide me with this, I can do the ios code.

Please send me your email, I send the file to you in private

mitchross · 2020-08-20T17:57:12Z

@rikaweb I need a video file to test this with thats hosted online. How did you test your android changes?

I add subtitles to video first and then test the change subtitle option.

Can you please provide specific instructions step by step? Local video? hosted video ? what code are you using to add subtitles? If you can provide me with this, I can do the ios code.

Please send me your email, I send the file to you in private

perfect.... mitchross09@gmail.com

rikaweb · 2020-08-20T18:12:10Z

@rikaweb I need a video file to test this with thats hosted online. How did you test your android changes?

I add subtitles to video first and then test the change subtitle option.

Can you please provide specific instructions step by step? Local video? hosted video ? what code are you using to add subtitles? If you can provide me with this, I can do the ios code.

Please send me your email, I send the file to you in private

perfect.... mitchross09@gmail.com

Sent!

mitchross · 2020-08-25T15:24:33Z

@rikaweb iOS changes implemented

dhruvkelawala · 2020-08-25T16:02:33Z

I hope this changes are merged soon in the package and published. Thanks @rikaweb @mitchross

solid-software · 2020-08-26T09:18:41Z

Great job - thanks @rikaweb @mitchross !

dhruvkelawala · 2020-09-04T05:32:32Z

How add a subtitle file (.srt) from network? @rikaweb @mitchross @solid-software

rikaweb · 2020-09-04T07:16:28Z

How add a subtitle file (.srt) from network? @rikaweb @mitchross @solid-software

you need first download the file then add it to VLC. VLC doesn't support network subtitles. you can use cache to that too.

dhruvkelawala · 2020-09-07T05:27:21Z

How add a subtitle file (.srt) from network? @rikaweb @mitchross @solid-software

you need first download the file then add it to VLC. VLC doesn't support network subtitles. you can use cache to that too.

Can't we make a helper function? Something like

controller.addSubtitle(Subtitle.fromNetwork(url));

Same with Subtitle.fromLocal(path)

mitchross · 2020-09-08T21:13:25Z

How add a subtitle file (.srt) from network? @rikaweb @mitchross @solid-software

you need first download the file then add it to VLC. VLC doesn't support network subtitles. you can use cache to that too.

Can't we make a helper function? Something like
controller.addSubtitle(Subtitle.fromNetwork(url));
Same with Subtitle.fromLocal(path)

submit a PR, I will review

alr2413 · 2020-09-09T06:02:09Z

I will submit a new PR and reference these issues there.

alr2413 · 2020-09-11T12:23:59Z

How add a subtitle file (.srt) from network? @rikaweb @mitchross @solid-software

you need first download the file then add it to VLC. VLC doesn't support network subtitles. you can use cache to that too.

Can't we make a helper function? Something like
controller.addSubtitle(Subtitle.fromNetwork(url));
Same with Subtitle.fromLocal(path)
submit a PR, I will review

I will submit a new PR and reference these issues there.

@dhruvkelawala , @mitchross , @solid-software
Here is my PR #104.

dhruvkelawala · 2020-09-11T12:30:39Z

Yes... I saw it. Looks great. It's upto @solid-software and @mitchross to approve it.

rikaweb added 6 commits April 24, 2020 22:24

ADD CHANGE SOUND AND SUBTITLE

76be67e

FIX AUDIO getAudioTrack typo

eaff38c

FIX AUDIO changSound typo

c57f26a

FIX AUDIO changSound typo

e227b21

Change Grade Version to 5.6.4

19ec91d

Merge remote-tracking branch 'upstream/master'

f816ec3

iOS Subtitles

6c61d33

update changelog

429bc2e

Merge branch 'master' into master

d3df0fa

solid-software merged commit 6fcee85 into solid-software:master Aug 26, 2020

shichunlei mentioned this pull request Oct 14, 2020

Message from debugger: Terminated due to memory issue #121

Open

Uh oh!

Conversation

rikaweb commented Aug 5, 2020

Uh oh!

alr2413 commented Aug 6, 2020

Uh oh!

solid-software commented Aug 6, 2020

Uh oh!

rikaweb commented Aug 6, 2020

Uh oh!

solid-software commented Aug 6, 2020

Uh oh!

rikaweb commented Aug 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mitchross commented Aug 10, 2020

Uh oh!

solid-software commented Aug 11, 2020

Uh oh!

alr2413 commented Aug 11, 2020

Uh oh!

rikaweb commented Aug 11, 2020

Uh oh!

mitchross commented Aug 11, 2020

Uh oh!

rikaweb commented Aug 11, 2020

Uh oh!

mitchross commented Aug 14, 2020

Uh oh!

rikaweb commented Aug 20, 2020

Uh oh!

mitchross commented Aug 20, 2020

Uh oh!

rikaweb commented Aug 20, 2020

Uh oh!

mitchross commented Aug 20, 2020

Uh oh!

rikaweb commented Aug 20, 2020

Uh oh!

mitchross commented Aug 25, 2020

Uh oh!

dhruvkelawala commented Aug 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solid-software commented Aug 26, 2020

Uh oh!

dhruvkelawala commented Sep 4, 2020

Uh oh!

rikaweb commented Sep 4, 2020

Uh oh!

dhruvkelawala commented Sep 7, 2020

Uh oh!

mitchross commented Sep 8, 2020

Uh oh!

alr2413 commented Sep 9, 2020

Uh oh!

alr2413 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhruvkelawala commented Sep 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rikaweb commented Aug 6, 2020 •

edited

Loading

dhruvkelawala commented Aug 25, 2020 •

edited

Loading

alr2413 commented Sep 11, 2020 •

edited

Loading