feat(@solidjs/start): vite 6 support#1756
Merged
birkskyum merged 6 commits intosolidjs:mainfrom Feb 7, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 6ac6dc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
More templates
commit: |
birkskyum
force-pushed
the
vite-6-bump
branch
from
59b1bba to
58d90b6
Compare
katywings
added a commit
to katywings/vinxi
that referenced
this pull request
Feb 5, 2025
…leGraph Importing a css file with "?url" results in "Error when evaluating SSR module" errors during "vite dev". The error is caused by Vinxi appending "&inline=true" for the ssrLoadModule calls. Vite "ssrLoadModule" expects urls to only have "?inline", the "url" parameter has to be removed. Refs: solidjs/solid-start#1756
katywings
added a commit
to katywings/vinxi
that referenced
this pull request
Feb 6, 2025
…leGraph Importing a css file with "?url" results in "Error when evaluating SSR module" errors during "vite dev". The error is caused by Vinxi appending "&inline=true" for the ssrLoadModule calls. Vite "ssrLoadModule" expects urls to only have "?inline", the "url" parameter has to be removed. Refs: solidjs/solid-start#1756
katywings
approved these changes
Feb 7, 2025
Contributor
katywings
left a comment
katywings
left a comment
There was a problem hiding this comment.
Looking good to me ❤️! P.S. I tested it with Vite 6.1 though 😅
birkskyum
force-pushed
the
vite-6-bump
branch
from
84438e7 to
642312e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1757
Closes #1679
This is a version of solid-start that's built with the latest vinxi packages / vite 6.
Thus I've added a peerDependency on
^0.5.1(and since there won't be more vinxi it's pinned).We can use the CR flow in this PR to validate it works in our projects.