fix(web): emit @solidjs/web/storage types at the advertised path#2875
Merged
ryansolid merged 1 commit intoJul 13, 2026
Merged
Conversation
|
storage tsconfig used rootDir "..", so tsc wrote types/storage/src/index.d.ts instead of types/index.d.ts that package.json exports. also clear storage/types on types:clean.
thribhuvan003
force-pushed
the
fix/solid-web-storage-types
branch
from
July 11, 2026 14:36
247e49d to
53f2bce
Compare
ryansolid
added a commit
that referenced
this pull request
Jul 13, 2026
…tsbuild Follow-up to #2875: rootDir ./src alone fails — the paths mapping pulled ../../src/index.ts into the program, and .ts inputs outside rootDir are a hard error. Pointing the mapping at ../../types/index.d.ts (built earlier in the types pipeline) keeps the program self-contained so the emit lands at storage/types/index.d.ts as advertised. Fixes #2873. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2873
package.json says
@solidjs/web/storagetypes live atstorage/types/index.d.ts, but the storage tsbuild hadrootDir: "..", so tsc put them understorage/types/storage/src/and consumers couldn't resolve the module.pointed
rootDirat./srcand clearstorage/typesintypes:clean. emit path after the fix istypes/index.d.ts.