Replace order strings with symbols/arel_table#298
Merged
Conversation
We should be testing behaviour instead of generated SQL
jhawthorn
force-pushed
the
association_order_symbols
branch
from
6f65cd0 to
632477f
Compare
There are some issues that some users can encounter to to a lack of
specific naming due to SQL errors on ordering. If the scope has
something like `.order('name')` it may cause a SQL error when we join
with another table that also has a name column.
As part of this, I got rid of a couple of generally terrible tests which
rely VERY heavily on their specific implementation.
jhawthorn
force-pushed
the
association_order_symbols
branch
from
632477f to
a50fd18
Compare
|
👍 |
jhawthorn
added a commit
that referenced
this pull request
Aug 18, 2015
Replace order strings with symbols/arel_table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rebase of #37 with feedback addressed. Also split part into #297
@athal7 I think this should have addressed your feedback in the previous PR.