use HABTM for zones and shipping methods#317
Merged
jhawthorn merged 3 commits intoAug 25, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Same question as other PR: Should we have an inverse of here, or is that detected successfully?
Contributor
Author
There was a problem hiding this comment.
I would assume it is...
Contributor
|
👍 I checked and it is. LGTM |
Contributor
|
👍 thanks for pulling this out |
jhawthorn
added a commit
that referenced
this pull request
Aug 25, 2015
use HABTM for zones and shipping methods
Contributor
Author
|
There's no dependent destroy added here. Also, what do you guys think of back tracking and adding foreign keys in this PR? |
This was referenced Oct 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.